refactor(lerobot): type metadata at import boundary - #381
Closed
victorwon2001 wants to merge 1 commit into
Closed
Conversation
|
👋 Hi @victorwon2001 — thanks for the contribution! To keep starter issues available You already have #380 open, so this one is being closed automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parse LeRobot
meta/info.jsononce into frozen internal dataset, episode, video-window, and numeric-feature values while keeping the downloaded JSON cache unchanged. Conversion now consumes those typed values directly, with existing paths, schemas, provenance, manifest contents, revision namespacing, and video-cache behavior preserved.Why
LeRobot feature specifications remained as nested raw dictionaries after the external JSON boundary, allowing metadata interpretation to be repeated later in discovery and conversion. Moving supported validation and normalization to the boundary makes invalid supported shapes unrepresentable internally without expanding dtype/rank support or changing canonical output behavior.
Fixes #320
Validation
uv run ruff check --fix— passeduv run ruff format— passeduv run ty check— passeduv run pytest -q tests/test_lerobot_converter.py— 47 passeduv run pytest -q— 1452 passed, 6 skippedgit diff --check— passedChecklist
uv run ruff check --fix,uv run ruff format, anduv run ty check.