Skip to content

Use jd/map->Properties on kafka-streams opts #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madstap wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use jd/map->Properties on kafka-streams opts #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e222e7
Use jd/map->Properties on kafka-streams opts
madstap Jun 3, 2020
c050c83
Merge branch 'master' into kafka-streams-parse-opts
madstap Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

* Allow map with keyword keys in streams constructor.

### Added

### Fixed
Expand All @@ -18,6 +20,7 @@

* Fix `ktable` constructor to use supplied `store-name`


* Bump `clj-uuid` version to `0.1.9`

* Minor update to fix harmless but distracting reflection warnings
Expand Down
7 changes: 3 additions & 4 deletions src/jackdaw/streams.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
{:license "BSD 3-Clause License <https://github.com/FundingCircle/jackdaw/blob/master/LICENSE>"}
(:refer-clojure :exclude [count map merge reduce group-by filter peek])
(:require [clojure.string :as str]
[jackdaw.data :as jd]
[jackdaw.streams.interop :as interop]
[jackdaw.streams.protocols :as p])
(:import org.apache.kafka.streams.KafkaStreams
Expand Down Expand Up @@ -315,10 +316,8 @@
(defn kafka-streams
"Makes a Kafka Streams object."
([builder opts]
(let [props (java.util.Properties.)]
(.putAll props opts)
(KafkaStreams. ^Topology (.build ^StreamsBuilder (streams-builder* builder))
^java.util.Properties props))))
(KafkaStreams. ^Topology (.build (streams-builder* builder))
(jd/map->Properties opts))))

(defn start
"Starts processing."
Expand Down