Use jd/map->Properties on kafka-streams opts#253
Open
madstap wants to merge 2 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 81.16% 81.25% +0.08%
==========================================
Files 41 41
Lines 2586 2560 -26
Branches 153 149 -4
==========================================
- Hits 2099 2080 -19
+ Misses 334 331 -3
+ Partials 153 149 -4
Continue to review full report at Codecov.
|
Contributor
|
LGTM. The existing integration tests should cover this change. e.g. this one which uses the |
cddr
previously approved these changes
Aug 5, 2020
Contributor
Author
|
Is there anything missing on my end for getting this PR merged? |
cddr
approved these changes
Oct 15, 2020
Contributor
Author
|
I suppose this isn't really high priority, but the PR has seen it's first birthday already. Any hope of getting it merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like an oversight, I found it confusing that I had to use string keys.
Checklist
Not sure how to go about testing this?