Say what the tree holds about the licence in the four documents that say it holds nothing - #167
Merged
Conversation
…say it holds nothing LICENSE is on the default branch carrying AGPL-3.0, and three documents plus one triage paragraph still said in the present tense that this repository has no licence file. Each of the three resolved fine and read as current, so a reader who believed them concluded they may not reuse anything here, which is the opposite of the terms the tree carries. docs/operator-guide.md tells a downloader what terms the thing arrived under. docs/promotion.md says what the code carries out and keeps the hand-over of somebody else's work blocked on entry three of #46, which carries no answer. SECURITY.md keeps the licence out of the set of things that are vulnerabilities. The triage paragraph in docs/supply-chain.md says the file has since landed and names the commit, with the License, 0 heading and the quoted warning left as the run this document declares reported them. None of the four says the declaration is made. DeclaredLicence is still empty and the licence leg still reports that it was not asked, so each document that mentions it points at #47 instead. Refs #163 Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #163
What this changes
LICENSEis on the default branch and carries AGPL-3.0. Three documents and onetriage paragraph still said, in the present tense, that this repository has no
licence file. Each of them now says what the tree holds, in the place its current
sentence sits and keeping what that sentence was doing for its reader.
docs/operator-guide.mdis the page somebody who downloads the runner opens, soit names the file, the licence and the link, and says the declaration is what is
still open rather than the file.
docs/promotion.mdis the checklist filled in at the moment work leaves thisboard, so its line says what the code carries out. The blocked half stays
blocked: entry three of #46 asks who may place a contributor's work under
another board's terms and carries no answer, so a hand-over of somebody else's
work still cannot be completed and that sentence is unchanged in substance.
SECURITY.mdkeeps the licence out of the set of things that arevulnerabilities, which is what its sentence was for. It does that by naming the
file and the open declaration instead of by naming an absence.
docs/supply-chain.mdis a different case. That document declares at the topthat every score in it comes from one named run, so the
License, 0heading andthe quoted warning are a faithful reading of that run and are untouched. Only the
triage prose under them changes: it says the file has since landed, names the
commit, and states plainly that the audit has not been re-run for this document.
The one command it adds is a reading of what the platform holds today and is not
a re-run of the triage.
None of the four says the declaration is made. Each one that mentions it points
at #47.
What failure it prevents
A reader who believes any of the three concludes they may not reuse anything
here, which is the opposite of the terms the tree carries. That is worse than a
broken link, because each of the three resolves fine and reads as current.
The triage paragraph failed in the other direction. It argued in the present
tense from an absence that has ended and pointed at an issue as the thing that
would end it, so a reader of the score page was told the repair was ahead of them
when it is behind.
What was run
At
8f3819af46d0959e5da2720f445633eca35b0270.The four readings the issue's done-when asks for, each returning nothing:
Four greps that return nothing are four greps that could each have missed
something, so here is the whole set of licence mentions left in tracked Markdown
outside the decision records and the fixtures, with the dependency-notices sense
of the word filtered out:
CONTRIBUTING.md:132andSECURITY.md:61are about somebody else's licencereaching this tree,
NOTICE.md:7is the notice pointing at the licence, anddocs/promotion.md:73is about whether the line was agreed rather than about whatit says. None of the four is a claim that the file is absent.
What the documents now assert, read at the source rather than from recollection:
The one command the supply-chain triage now pastes, re-run against the live
platform at this commit:
The declaration leg, unmoved, quoted because three of the four documents now say
it is the thing that is open:
The four commands
CONTRIBUTING.mdnames, in its order. The first three printednothing, which is what they say when they pass:
The hardware suite behind the build constraint was not run. It is asked for
explicitly and nothing here asked for it, so what it would have said about a
change to four Markdown files is unmeasured rather than green.
The checker against this checkout:
The paths this change touches are the four the issue names and nothing else:
What this does not do
It does not answer the declaration question.
DeclaredLicenceis empty, thelicence leg still reports that it was not asked, and none of the four documents
is edited to say otherwise. That is #47.
It does not re-run the supply-chain audit. The
License, 0heading, the quotedwarning and the aggregate above them are the run that document declares at its
top, left exactly as that run reported them. The alert state pasted in the triage
is what the platform holds today, which is a different reading from a re-run and
is written as one.
It adds no guard, so there is no proof by deletion to show. The three links it
adds are read by no check here, and that is measured rather than assumed.
[LICENSE](LICENSE)inSECURITY.mdsits beside the same link inREADME.md,which is already the subject, so the count of paths the invariants examine is the
same with this change and without it:
The two
[LICENSE](../LICENSE)links fromdocs/are not read at all, and thatis a gap in the paths leg rather than a property of this change.
PathsNamedInProserequires a leading segment naming a directory of this treeand
..is not one, andLinkTargetsWithoutADirectoryskips any targetcontaining a slash, so a link from a document in
docs/to a file at the rootfalls between the two readings.
[NOTICE.md](../NOTICE.md)in the same documenthas been in that state since before this change. It is written up as its own
issue rather than repaired here, because widening either reading is a change to a
guard and belongs with the guard.
No second reader was available for this change. It carries the commands above in
place of one, and the run that was not made is written as not made rather than
left out.
Why this is the second pull request for this issue
The first was #166, whose head carried no
Signed-off-bytrailer, and the DCOgate refused it by name:
The commit here is that one cherry-picked with the trailer, so the content is the
same and the history is not rewritten. #166 is closed with this reason in its
body and its branch is left where it is. The other checks on that head had passed
or were still running when it was refused, and this head is judged on its own
run rather than on that one.