I15-1: Get container info on playlist and display if it's not mounted - #159
Open
DominicOram wants to merge 6 commits into
Open
I15-1: Get container info on playlist and display if it's not mounted#159DominicOram wants to merge 6 commits into
DominicOram wants to merge 6 commits into
Conversation
This was referenced Aug 18, 2026
DominicOram
marked this pull request as ready for review
August 18, 2026 12:47
Contributor
Author
|
With #163 merged i'll fix the typing on this now |
jacob-williamson
approved these changes
Aug 19, 2026
Collaborator
There was a problem hiding this comment.
Looks good, just one question.
Also a small UX nit, I think the warning message may be more discoverable if the row had a warning icon somewhere, probably on the far right. And then if you hovered over this warning icon, it could tell you the message, similar to how we want to show the errors when we hover over the error icon in the queue view. Happy to merge as is though and we can add this in later if we want to
| enableDensityToggle: false, | ||
| enableFullScreenToggle: false, | ||
| muiTableBodyRowProps: ({ row }) => { | ||
| const showWarning = hasContainerNotOnTable(row.original); |
Collaborator
There was a problem hiding this comment.
Shouldn't we also flag if a sample's container is null? As this presumably means we don't know where it is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #115
To test:
fakeExperimentsstructure inhandlersmatches what is returned in gql from the new getSession... query