Skip to content

Use container info as passed in from ULIMS - #89

Open
DominicOram wants to merge 3 commits into
mainfrom
atlas_115_use_container_info
Open

Use container info as passed in from ULIMS#89
DominicOram wants to merge 3 commits into
mainfrom
atlas_115_use_container_info

Conversation

@DominicOram

Copy link
Copy Markdown
Contributor

Fixes DiamondLightSource/atlas#115

To test:

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (016ac31) to head (8571184).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   98.76%   98.77%           
=======================================
  Files          18       18           
  Lines         889      896    +7     
=======================================
+ Hits          878      885    +7     
  Misses         11       11           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacob-williamson jacob-williamson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, haven't yet reviewed the atlas side but tried the UI which works well.

# Need to get sample info for test samples (air, empty capillary etc)
sample=Sample(name="fq_1_1", id="", data={}),
sample=Sample(
name="fq_1_1",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could change this to something more sensible now that we don't use it to work out the positon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i15-1: Pass sample location to queue based on container logistics

2 participants