Add "reverse" (red) styling on Commodore 64

[dstelzer]

[dstelzer]

@sehugg Requesting review on this one; it's a fairly straightforward addition, but I want to make sure it works with your Apple II implementation.

[dstelzer]

(I'm also open to feedback on the colors; I'm color-blind so what looks good to me does not always look good to others.)

[sehugg]

I see one issue, I think you meant:

ldy #cssparam_none

There are still a pair of bugs in the Apple frontend and engine that affect using styles with reverse video (opcodes are fine) so until I fix those it may look ugly.

Also I would swap the first and last colors, orange is a natural fit with blue.

[dstelzer]

Oops! Good catch.

I tried it out on the Apple II with the reverse opcode, but it seems to fall out of reverse mode every time a new div or span is entered, which makes it hard to see the effect.

[dstelzer]

Hmmm…

[sehugg]

I like the cold/warm split. But what about making reverse normal = white? Italics and bold could still be warm colors.

[dstelzer]

Oh, interesting! I thought the background on this interpreter was "white", not "light gray". That means a more proper reverse is actually possible (light against the background instead of dark against the background).

Reverse-italics could then be red and pink; but what about reverse-bold?

[sehugg]

I like the yellow for reverse-bold, it's orthogonal to the light gray of the normal bold.

[dstelzer]

So like this?

[sehugg]

Yeah! Looks good!

[dstelzer]

The poll is currently neck and neck. I'm counting you as a vote for "reverse is white, reverse italic is red", which puts that on top by one, but I'll give people a bit longer to weigh in if they want to.