Skip to content

Fix: return type contract violation and doc typo in try_download_result tool #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyun-hyang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: return type contract violation and doc typo in try_download_result tool #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/rodin_mcp/rodin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,12 @@ async def download_file(client: httpx.AsyncClient, url: str, file_path: str, ret
@server.tool()
async def try_download_result(
parameters: DownloadRequestParameters
) -> str | tuple[str, Optional[MCPImage], str]:
) -> str | tuple[Optional[MCPImage], str]:
"""
This tool will try to download the generated assets if the Rodin completed the generation task.

[Notes]
- Always make sure an absolute path is given bu the user before calling this tool.
- Always make sure an absolute path is given by the user before calling this tool.
- The tool expects a directory for the download_to_path parameter.
- The tool will download files to {download_to_path}/{uuid}/ directory
- So when giving example, don't include the filename
Expand Down