Fix: return type contract violation and doc typo in try_download_result tool#1
Open
hyun-hyang wants to merge 1 commit into
Open
Fix: return type contract violation and doc typo in try_download_result tool#1hyun-hyang wants to merge 1 commit into
hyun-hyang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Report (Issue substitute)
This PR documents and fixes a contract violation bug in the MCP tool
try_download_result.Issues
Bug Evidence
1. Return type contract violation
Before
Declared return type:
rodin-api-mcp/src/rodin_mcp/rodin.py
Line 98 in 855b2a8
Actual return value:
rodin-api-mcp/src/rodin_mcp/rodin.py
Line 136 in 855b2a8
rodin-api-mcp/src/rodin_mcp/rodin.py
Lines 166 to 170 in 855b2a8
This violates both tuple length and positional ordering, which is critical
in MCP environments where tuple order is semantically significant.
After (this PR)
2. Docstring typo
rodin-api-mcp/src/rodin_mcp/rodin.py
Line 103 in 855b2a8
Fix applied in this PR
Visual reference (GitHub UI diff)