[ACTP] flesh out par-control lifecycle code

[embeaken]

What does this PR do?

Stacks on #54439 and fleshes out the standalone par-control lifecycle code:

• Loads and validates Private Action Runner split-mode configuration.
• Connects to dd-procmgrd over Unix sockets or Windows named pipes.
• Starts, monitors, and shuts down the existing privateactionrunner run-executor process.
• Adds the protocol bindings, transport, process-manager client, build wiring, and unit tests.

This slice does not wire split mode into the monolithic Go runner and does not package or activate par-control.

Motivation

Keep the control-plane implementation reviewable independently from Agent runner integration and packaging.

Describe how you validated your changes

• bazel test //pkg/privateactionrunner/par-control:par-control_test

Additional Notes

This is a draft stacked PR based on #54439.

[chatgpt-codex-connector]

💡 Codex Review

datadog-agent/pkg/privateactionrunner/par-control/src/config.rs

Lines 132 to 135 in b9f8762

	match raw.trim().to_ascii_lowercase().as_str() {
	"true" => Ok(true),
	"false" => Ok(false),
	_ => bail!("invalid boolean value for {name}: {raw:?}"),

Accept Agent-compatible boolean environment values

When split mode is configured with standard Agent-compatible boolean values such as DD_PRIVATE_ACTION_RUNNER_ENABLED=1 and DD_PRIVATE_ACTION_RUNNER_SPLIT_ENABLED=1, the Go configuration layer accepts them through cast.ToBoolE and shuts down the monolithic runner, but this parser rejects them and terminates par-control. That leaves neither control plane running. Parse the same boolean spellings supported by the Agent configuration layer rather than accepting only true and false.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[dd-octo-sts]

Static quality checks

❌ Please find below the results from static quality gates
Comparison made with ancestor fd17682
📊 Static Quality Gates Dashboard
🔗 SQG Job

Error

	Quality gate	Change	Size (prev → curr → max)
❌	agent_rpm_arm64 (on disk)	+36.16 KiB (0.00% increase, -1319.46% of buffer)	734.027 → 734.063 → 734.030
❌	agent_suse_arm64 (on disk)	+36.16 KiB (0.00% increase, -1319.46% of buffer)	734.027 → 734.063 → 734.030

Gate failure full details

Quality gate	Error type	Error message
agent_rpm_arm64	AbsoluteLimitExceeded	static_quality_gate_agent_rpm_arm64 failed! Disk size 734.1 MB exceeds limit of 734.0 MB by 33.4 KB
agent_suse_arm64	AbsoluteLimitExceeded	static_quality_gate_agent_suse_arm64 failed! Disk size 734.1 MB exceeds limit of 734.0 MB by 33.4 KB

Static quality gates prevent the PR to merge!
You can check the static quality gates confluence page for guidance. We also have a toolbox page available to list tools useful to debug the size increase.
Please either fix the size violation or request an exception.

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+32.16 KiB (0.00% increase, -0.64% of buffer)	757.969 → 758.001 → 762.870
✅	agent_deb_amd64_fips	+8.0 KiB (0.00% increase, -0.28% of buffer)	711.374 → 711.382 → 714.170
✅	agent_msi	+41.78 KiB (0.01% increase, -0.23% of buffer)	639.611 → 639.652 → 657.290
✅	agent_rpm_amd64	+32.16 KiB (0.00% increase, -0.64% of buffer)	757.953 → 757.985 → 762.840
✅	agent_rpm_amd64_fips	+8.0 KiB (0.00% increase, -0.28% of buffer)	711.357 → 711.365 → 714.170
✅	agent_rpm_arm64_fips	+12.0 KiB (0.00% increase, -0.76% of buffer)	690.711 → 690.722 → 692.250
✅	agent_suse_amd64	+32.16 KiB (0.00% increase, -0.64% of buffer)	757.953 → 757.985 → 762.840
✅	agent_suse_amd64_fips	+8.0 KiB (0.00% increase, -0.28% of buffer)	711.357 → 711.365 → 714.170
✅	agent_suse_arm64_fips	+12.0 KiB (0.00% increase, -0.76% of buffer)	690.711 → 690.722 → 692.250
✅	docker_agent_amd64	+32.15 KiB (0.00% increase, -1.72% of buffer)	816.632 → 816.663 → 818.460
✅	docker_agent_arm64	+36.15 KiB (0.00% increase, -2.29% of buffer)	817.761 → 817.796 → 819.300
✅	docker_agent_jmx_amd64	+32.16 KiB (0.00% increase, -1.86% of buffer)	1007.529 → 1007.561 → 1009.220
✅	docker_agent_jmx_arm64	+36.15 KiB (0.00% increase, -2.12% of buffer)	997.311 → 997.346 → 998.980
✅	docker_cluster_agent_amd64	+12.03 KiB (0.01% increase, -1.08% of buffer)	210.161 → 210.173 → 211.250
✅	docker_dogstatsd_arm64	+64.0 KiB (0.17% increase, -8.09% of buffer)	37.498 → 37.560 → 38.270
✅	iot_agent_deb_amd64	+4.0 KiB (0.01% increase, -54.38% of buffer)	46.373 → 46.377 → 46.380
✅	iot_agent_rpm_amd64	+4.0 KiB (0.01% increase, -58.36% of buffer)	46.373 → 46.377 → 46.380
✅	iot_agent_suse_amd64	+4.0 KiB (0.01% increase, -50.30% of buffer)	46.372 → 46.376 → 46.380

13 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_heroku_amd64	312.171 MiB
✅	docker_cluster_agent_arm64	223.204 MiB
✅	docker_cws_instrumentation_amd64	7.439 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.428 MiB
✅	docker_host_profiler_amd64	305.753 MiB
✅	docker_host_profiler_arm64	317.048 MiB
✅	dogstatsd_deb_amd64	30.169 MiB
✅	dogstatsd_deb_arm64	28.197 MiB
✅	dogstatsd_rpm_amd64	30.169 MiB
✅	dogstatsd_suse_amd64	30.169 MiB
✅	iot_agent_deb_arm64	43.052 MiB
✅	iot_agent_deb_armhf	43.820 MiB

[dd-octo-sts]

Go Package Import Differences

Baseline: fd17682
Comparison: 55e32f6

binary	os	arch	change
privateactionrunner	linux	amd64	+2, -0 +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/controlconfig +github.com/DataDog/datadog-agent/pkg/privateactionrunner/controlconfig
privateactionrunner	linux	arm64	+2, -0 +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/controlconfig +github.com/DataDog/datadog-agent/pkg/privateactionrunner/controlconfig
privateactionrunner	windows	amd64	+2, -0 +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/controlconfig +github.com/DataDog/datadog-agent/pkg/privateactionrunner/controlconfig
privateactionrunner	darwin	amd64	+2, -0 +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/controlconfig +github.com/DataDog/datadog-agent/pkg/privateactionrunner/controlconfig
privateactionrunner	darwin	arm64	+2, -0 +github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/controlconfig +github.com/DataDog/datadog-agent/pkg/privateactionrunner/controlconfig

[datadog-official]

🎯 Code Coverage (details)
• Patch Coverage: 81.42%
• Overall Coverage: 52.29% (+0.03%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 55e32f6 | Docs | Datadog PR Page | Give us feedback!}

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9227497c-f3a3-4c06-9d2b-f0b8d5bc0b2a

Baseline: 079eb1d
Comparison: 55e32f6
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.78	[+0.93, +2.63]	1	Logs bounds checks dashboard
➖	quality_gate_private_action_runner	memory utilization	+0.32	[+0.20, +0.44]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	+0.29	[+0.05, +0.54]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.15	[+0.11, +0.18]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.07	[+0.02, +0.12]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	-0.03	[-0.13, +0.07]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	-0.15	[-0.21, -0.10]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	-0.21	[-0.25, -0.17]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	149.36MiB ≤ 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	734.45KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	491.96MiB ≤ 512MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	183.66MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	263.98MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	362.18 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	387.16MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_private_action_runner	memory_usage	10/10	72.36MiB ≤ 75MiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	27.47 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	305.15MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	62.49 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	280.05MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	23.02 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	294.59MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_idle	baseline	10	Oom killed	Debug Dashboard
quality_gate_security_idle	comparison	10	Crashed (exit code: 134)	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor fd176825:

Results for datadog-agent_7.84.0~devel.git.44.55e32f6.pipeline.129688480-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.44.55e32f6.pipeline.129688480-1_amd64.deb:

No change detected

[embeaken]

Superseded by the focused replacement stack #54439 → #54589 → #54590 → #54591 → #54592 → #54593 → #54594 → #54529 (GitHub stack #54595).