Skip to content

[ACTP] wire par-control into the existing runner - #54533

Closed
embeaken wants to merge 1 commit into
ilya/par-control-integrationfrom
ilya/par-control-runner-wiring
Closed

[ACTP] wire par-control into the existing runner#54533
embeaken wants to merge 1 commit into
ilya/par-control-integrationfrom
ilya/par-control-runner-wiring

Conversation

@embeaken

@embeaken embeaken commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Stacks on #54531 and wires split mode into the existing Private Action Runner:

  • Adds the default-off private_action_runner.split_enabled setting.
  • Makes the monolithic Go runner stand down on Linux and Windows when split mode is enabled.
  • Treats the split-deployment sentinel as a clean exit from the existing run command.
  • Adds coverage for platform-specific split-mode behavior.

Motivation

Keep the existing-runner integration separate from the Rust par-control implementation and downstream packaging work.

Describe how you validated your changes

  • dda inv test --targets=./comp/privateactionrunner/impl

Additional Notes

This is a draft stacked PR based on #54531.

@embeaken
embeaken force-pushed the ilya/par-control-integration branch from 0c700ba to 5035d15 Compare August 6, 2026 18:00
@embeaken
embeaken force-pushed the ilya/par-control-runner-wiring branch from aa6db14 to 3564748 Compare August 6, 2026 18:01
@embeaken
embeaken force-pushed the ilya/par-control-runner-wiring branch 2 times, most recently from 8f3dd5f to 9baf977 Compare August 6, 2026 18:34
@dd-octo-sts

dd-octo-sts Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Go Package Import Differences

Baseline: 282b91c
Comparison: 9761287

binaryosarchchange
privateactionrunnerlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/controlconfig
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/controlconfig
privateactionrunnerlinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/controlconfig
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/controlconfig
privateactionrunnerwindowsamd64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/controlconfig
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/controlconfig
privateactionrunnerdarwinamd64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/controlconfig
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/controlconfig
privateactionrunnerdarwinarm64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/controlconfig
+github.com/DataDog/datadog-agent/pkg/privateactionrunner/controlconfig

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 60.00%
Overall Coverage: 52.24% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9761287 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 282b91c
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +32.18 KiB (0.00% increase, -0.62% of buffer) 757.779 → 757.810 → 762.870
agent_deb_amd64_fips +11.99 KiB (0.00% increase, -0.40% of buffer) 711.261 → 711.273 → 714.170
agent_heroku_amd64 +8.0 KiB (0.00% increase, -0.12% of buffer) 312.140 → 312.147 → 318.880
agent_msi +42.28 KiB (0.01% increase, -0.23% of buffer) 639.454 → 639.495 → 657.290
agent_rpm_amd64 +32.18 KiB (0.00% increase, -0.62% of buffer) 757.762 → 757.794 → 762.840
agent_rpm_amd64_fips +11.99 KiB (0.00% increase, -0.40% of buffer) 711.245 → 711.257 → 714.170
agent_rpm_arm64 +36.68 KiB (0.00% increase, -19.84% of buffer) 733.849 → 733.885 → 734.030
agent_rpm_arm64_fips +12.49 KiB (0.00% increase, -0.74% of buffer) 690.611 → 690.623 → 692.250
agent_suse_amd64 +32.18 KiB (0.00% increase, -0.62% of buffer) 757.762 → 757.794 → 762.840
agent_suse_amd64_fips +11.99 KiB (0.00% increase, -0.40% of buffer) 711.245 → 711.257 → 714.170
agent_suse_arm64 +36.68 KiB (0.00% increase, -19.84% of buffer) 733.849 → 733.885 → 734.030
agent_suse_arm64_fips +12.49 KiB (0.00% increase, -0.74% of buffer) 690.611 → 690.623 → 692.250
docker_agent_amd64 +32.18 KiB (0.00% increase, -1.56% of buffer) 816.441 → 816.472 → 818.460
docker_agent_arm64 +36.67 KiB (0.00% increase, -2.09% of buffer) 817.583 → 817.619 → 819.300
docker_agent_jmx_amd64 +32.17 KiB (0.00% increase, -1.67% of buffer) 1007.338 → 1007.370 → 1009.220
docker_agent_jmx_arm64 +36.67 KiB (0.00% increase, -1.94% of buffer) 997.133 → 997.169 → 998.980
docker_cluster_agent_amd64 +8.03 KiB (0.00% increase, -0.71% of buffer) 210.141 → 210.149 → 211.250
iot_agent_deb_arm64 +4.0 KiB (0.01% increase, -0.58% of buffer) 43.045 → 43.049 → 43.720
15 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
docker_cluster_agent_arm64 223.204 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.428 MiB
docker_dogstatsd_arm64 37.560 MiB
docker_host_profiler_amd64 305.753 MiB
docker_host_profiler_arm64 317.048 MiB
dogstatsd_deb_amd64 30.169 MiB
dogstatsd_deb_arm64 28.197 MiB
dogstatsd_rpm_amd64 30.169 MiB
dogstatsd_suse_amd64 30.169 MiB
iot_agent_deb_amd64 46.373 MiB
iot_agent_deb_armhf 43.816 MiB
iot_agent_rpm_amd64 46.373 MiB
iot_agent_suse_amd64 46.372 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 6, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d0cdc105-60cb-4b82-9e94-dfe5a39b74ad

Baseline: 282b91c
Comparison: 9761287
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.80 [+0.92, +2.67] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.51 [+0.27, +0.75] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.27 [+0.23, +0.31] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.20 [+0.14, +0.26] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.19 [+0.15, +0.24] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.05 [-0.05, +0.14] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.34 [-0.38, -0.30] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization -0.40 [-0.52, -0.28] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 149.49MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 730.38KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 491.06MiB ≤ 512MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 185.92MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.16MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 391.06 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 382.27MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.21MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 25.86 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 307.05MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 62.05 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 279.40MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 21.14 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 288.60MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle comparison 10 Oom killed Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_idle comparison 10 Oom killed Debug Dashboard
quality_gate_security_mean_fs_load baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@embeaken
embeaken force-pushed the ilya/par-control-integration branch from 9e0d3c3 to 759cec9 Compare August 6, 2026 20:19
@embeaken
embeaken force-pushed the ilya/par-control-runner-wiring branch from 9baf977 to 9761287 Compare August 6, 2026 20:19
@dd-octo-sts

dd-octo-sts Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 282b91cf:

Results for datadog-agent_7.83.0~devel.git.667.9761287.pipeline.129511066-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.83.0~devel.git.667.9761287.pipeline.129511066-1_amd64.deb:

No change detected

@embeaken

embeaken commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Folded into #54529 so the runner wiring and packaging/activation changes can be reviewed as one cohesive PR.

@embeaken embeaken closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant