Skip to content

Fix Show Buffs/Show Debuffs toggles not applying live until /reload #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Krathe82 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Show Buffs/Show Debuffs toggles not applying live until /reload #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
882e989
Fix Show Buffs/Show Debuffs toggles not applying live until reload
Krathe82 Jun 16, 2026
16a5699
Changelog: add #165 entry to CHANGELOG.md (the build's source)
Krathe82 Jun 16, 2026
ea4a8cb
Changelog: drop Changelog.lua edit (generated from CHANGELOG.md at bu…
Krathe82 Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
* (Aura Designer) Text-only icons no longer draw a leftover border (static or expiring). (by Krathe)
* (Aura Designer) Aura icon and square borders from older profiles keep their original look after the border rework, instead of appearing thinner or floating in a gap. (by Krathe)
* (Buff/Debuff) Icon borders from older profiles no longer float in a gap after the border rework — they hug the icon as before. (by Krathe)
* (Buff/Debuff) **Show Buffs / Show Debuffs** toggles now apply live without a `/reload` — already-shown auras hide or reappear immediately instead of lingering until the unit's next aura change. (by Krathe)

## [4.4.1]

Expand Down
10 changes: 8 additions & 2 deletions Options/Options.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5831,7 +5831,11 @@ function DF:SetupGUIPages(GUI, CreateCategory, CreateSubTab, BuildPage)
settingsGroup:AddWidget(GUI:CreateHeader(self.child, L["Settings"]), 40)
local showBuffsCb = settingsGroup:AddWidget(GUI:CreateCheckbox(self.child, L["Show Buffs"], db, "showBuffs", function()
self:RefreshStates()
DF:UpdateAllFrames()
-- Re-scan auras on visible frames (not just layout): the show/hide gate
-- lives in the UNIT_AURA-driven UpdateAuras path, so UpdateAllFrames alone
-- (layout-only) leaves already-shown auras until the next aura event. Use
-- the same refresh the Max Buffs slider uses.
DF:RefreshAllVisibleFrames()
end), 30)
-- Re-sync checked state when value changes externally (e.g. AD banner click)
showBuffsCb.refreshContent = function(self)
Expand Down Expand Up @@ -6040,7 +6044,9 @@ function DF:SetupGUIPages(GUI, CreateCategory, CreateSubTab, BuildPage)
settingsGroup:AddWidget(GUI:CreateHeader(self.child, L["Settings"]), 40)
settingsGroup:AddWidget(GUI:CreateCheckbox(self.child, L["Show Debuffs"], db, "showDebuffs", function()
self:RefreshStates()
DF:UpdateAllFrames()
-- See Show Buffs above: re-scan auras on visible frames so a static
-- debuff hides/shows immediately instead of waiting for the next aura event.
DF:RefreshAllVisibleFrames()
end), 30)
local dispelHighlight = settingsGroup:AddWidget(GUI:CreateCheckbox(self.child, L["Highlight Dispellable"], db, "dispellableHighlight", nil), 30)
dispelHighlight.disableOn = function(d) return not d.showDebuffs end
Expand Down