Fix Show Buffs/Show Debuffs toggles not applying live until /reload#165
Open
Krathe82 wants to merge 3 commits into
Open
Fix Show Buffs/Show Debuffs toggles not applying live until /reload#165Krathe82 wants to merge 3 commits into
Krathe82 wants to merge 3 commits into
Conversation
The Show Buffs / Show Debuffs checkbox callbacks ran DF:UpdateAllFrames(), which only re-applies frame layout and leaves aura updates to UNIT_AURA events. The actual show/hide gate lives in DF:UpdateAuras_Enhanced, so an already-shown aura kept its state until the unit's next aura event (or a /reload). Buffs appeared to update instantly only because they churn often; a static debuff lingered. Switch both callbacks to DF:RefreshAllVisibleFrames(), which re-runs the aura scan per visible frame (RefreshLiveFrames -> FullFrameRefresh -> UpdateAuras) - the same refresh the adjacent Max Buffs/Max Debuffs sliders already use.
Krathe82
added a commit
to Krathe82/DandersFrames
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Toggling Show Buffs / Show Debuffs in settings didn't take effect on live frames immediately. The value saved correctly, but already-shown auras kept their previous shown/hidden state until a
/reloador the unit's next aura event. (Test mode was unaffected — it redraws on the spot, which is why it was easy to miss.)Root cause
Both checkbox callbacks ran
self:RefreshStates()+DF:UpdateAllFrames().UpdateAllFramesonly re-applies frame layout (ApplyFrameLayout) — its own comment notes that unit/aura data updates are left toUNIT_*events. The actual show/hide gate lives inDF:UpdateAuras_Enhanced(buffs/debuffs), which is UNIT_AURA-driven and never invoked by the toggle. So an already-applied aura kept its state until its unit fired the nextUNIT_AURA. Buffs looked instant only because they churn constantly; a static debuff lingered until a/reload.Fix
Switch both callbacks to
DF:RefreshAllVisibleFrames(), which re-runs the aura scan per visible frame (RefreshLiveFrames→FullFrameRefresh→DF:UpdateAuras→ the gate). This is the same refresh the adjacent Max Buffs / Max Debuffs sliders already use, so it's an existing, proven path — not a new mechanism. It also handles test mode, making it a strict superset of the prior behaviour.Scope
Options/Options.lua— two callbacks (Show Buffs, Show Debuffs).Changelog.lua— one Bug Fixes entry.No data/persistence change; purely a live-refresh fix.