perf(frontend): decode ERD handles without column rescans - #700
perf(frontend): decode ERD handles without column rescans#700seonghobae wants to merge 39 commits into
Conversation
* Created O(1) `decodeHandleId` utility in `handleUtils.ts`. * Avoid O(N * C) array mapping loops inside export generators. * Removes massive object allocations during iterative string comparisons. * Strict null checks allow correct exporting of empty column name edges.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (5)
📝 WalkthroughWalkthroughERD 핸들 ID를 직접 디코드하는 ChangesERD 핸들 디코딩 및 외래 키 매칭
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ReactFlowEdge
participant decodeHandleId
participant ERDExporter
participant DataDictionaryExporter
ReactFlowEdge->>decodeHandleId: sourceHandle 전달
decodeHandleId-->>ERDExporter: 디코드된 컬럼명 반환
ERDExporter->>ERDExporter: 컬럼 존재 여부 확인
decodeHandleId-->>DataDictionaryExporter: 디코드된 컬럼명 반환
DataDictionaryExporter->>DataDictionaryExporter: 외래 키 컬럼 집합 확인
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
@jules Please update this PR branch with a focused follow-up commit:
|
Thank you for the review. I have removed the unused imports in |
…cations * Fold the non-allocating string builder into `sanitizeHandleId` * Remove unused `sourceColumnHandleId` and `targetColumnHandleId` imports from `export.ts`
|
@jules One additional correctness/performance pass is required on the new decoder before merge:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/erd/export.ts`:
- Around line 70-81: Update frontend/src/erd/export.ts lines 70-81 by building
reusable per-node column-name Sets or Maps once at export start, then have the
sourceHandleColumn and targetHandleColumn resolution use decoded handles for
index lookups without creating indexes per edge; update .jules/bolt.md lines
80-82 to remove the O(1) claim and state that the change only eliminates
re-encoding and temporary allocations while retaining linear searches.
In `@frontend/src/erd/handleUtils.ts`:
- Around line 25-44: Update frontend/src/erd/handleUtils.ts:25-44 in
decodeHandleId to accept only c-…, src-c-…, and tgt-c-… prefixes, with payloads
limited to empty or 4–6 lowercase hexadecimal digits per chunk; reject invalid
prefixes, empty or mixed payloads, uppercase hex, partial hex such as 0064junk,
and code points such as 110000 while preserving lone-surrogate round trips. Add
the requested regression coverage in frontend/src/erd/handleUtils.test.ts:39-69,
including tgt-c-empty. Preserve null-skipping behavior in
frontend/src/erd/export.ts:73-81 and
frontend/src/erd/exportDataDictionary.ts:60-66, and extend
frontend/src/erd/__tests__/exportDataDictionary.test.ts:149-164 to verify
c-0069-0064junk does not create an FK.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4284f446-f639-46fb-a801-2dcf00ac96bc
📒 Files selected for processing (6)
.jules/bolt.mdfrontend/src/erd/__tests__/exportDataDictionary.test.tsfrontend/src/erd/export.tsfrontend/src/erd/exportDataDictionary.tsfrontend/src/erd/handleUtils.test.tsfrontend/src/erd/handleUtils.ts
Thank you for the detailed feedback. I have implemented a strict regex to validate canonical payload forms and correct bounds check in |
* Rewrite `decodeHandleId` to strictly evaluate payload chunks via regex, correctly handling junk boundaries, missing prefixes, and malformed inputs. Add comprehensive vitest coverage. * Upgrade `export.ts` foreign key mapping lookup to explicitly precompute Sets instead of implicitly relying on Array `.find()`.
|
@jules 이 PR의 기능은 새 npm 의존성을 추가하지 않는데 |
I have completely rolled back the |
* Reverted unintended version modifications to devDependencies (vitest) to prevent out-of-scope package bumps during the optimization PR. * Verified via clean `npm ci`, typecheck, lint, coverage, and build.
seonghobae
changed the title
Pull request was converted to draft
|
@opencode-agent Please review exact current head |
|
@cwl-noema-review Please independently review exact current head |
Acknowledged. |
Acknowledged. |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headcd2b9edb11d2900003b036782f835fd183395492. -
Head SHA:
cd2b9edb11d2900003b036782f835fd183395492 -
Workflow run: 30960467857
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: bolt.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: bolt.md"]
R1 --> V1["required checks"]
Evidence --> S2["Frontend (9 files)"]
S2 --> I2["browser runtime and bundle"]
I2 --> R2["Review risk: Frontend (9 files)"]
R2 --> V2["frontend tests"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: bolt.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: bolt.md"]
R1 --> V1["required checks"]
Evidence --> S2["Frontend (9 files)"]
S2 --> I2["browser runtime and bundle"]
I2 --> R2["Review risk: Frontend (9 files)"]
R2 --> V2["frontend tests"]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headcbf01df2f3fec84162f8462802265235cdf50c5e. -
Head SHA:
cbf01df2f3fec84162f8462802265235cdf50c5e -
Workflow run: 31021253470
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: bolt.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: bolt.md"]
R1 --> V1["required checks"]
Evidence --> S2["Frontend (9 files)"]
S2 --> I2["browser runtime and bundle"]
I2 --> R2["Review risk: Frontend (9 files)"]
R2 --> V2["frontend tests"]
2 participants
What
Add a validated
decodeHandleIdutility and use it in ERD export paths instead of repeatedly rebuilding and comparing encoded handles for every candidate column.Why
The previous export logic scanned table columns and re-encoded each candidate while resolving edge handles. For a table with
Ccolumns and handle lengthH, that lookup performed repeatedO(C × H)string work. The new path decodes the handle directly inO(H), eliminating the column scan and substantially reducing transient allocations on dense diagrams.Scope
c-*,src-c-*, andtgt-c-*handles with strict hexadecimal and Unicode-code-point validation.Verification
The required current-head workflow must run:
cd frontend npm ci npm run typecheck npm run coverage npm run buildOriginally created by Jules for task 17383827529551263442.