Skip to content

⚡ Bolt: 최적화된 FK 핸들 조회 및 디코딩 성능 개선 - #739

Closed
seonghobae wants to merge 1 commit into
mainfrom
bolt-export-fk-lookup-optimization-9237828092970570825
Closed

⚡ Bolt: 최적화된 FK 핸들 조회 및 디코딩 성능 개선#739
seonghobae wants to merge 1 commit into
mainfrom
bolt-export-fk-lookup-optimization-9237828092970570825

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What:

  • Added a new helper function parseColumnNameFromHandle in frontend/src/erd/handleUtils.ts that decodes the hex-encoded column name from an edge handle ID in O(1) time.
  • Updated fkColumnsForEdge in frontend/src/erd/export.ts to directly decode the edge.sourceHandle and edge.targetHandle and perform a simple existence check (some()) rather than re-encoding all columns on a node.

🎯 Why:

  • Previously, resolving foreign key columns from edge handles used an O(N*C) loop that redundantly hex-encoded every column on a node to find a matching handle. This creates heavy allocation and iteration bottlenecks for large schemas.

📊 Impact:

  • Removes an O(N*C) string encoding loop from the hot path during export. Replaces it with a single O(1) string decode and O(N) strict string equality existence check per edge, reducing CPU cycles and garbage collection overhead during large diagram exports.

🔬 Measurement:

  • Run tests using cd frontend && pnpm test -- src/erd/handleUtils.test.ts to verify the decoding logic works correctly across ascii, unicode, emojis, and invalid inputs. Verify pnpm run typecheck and pnpm test pass cleanly.

PR created automatically by Jules for task 9237828092970570825 started by @seonghobae

Replaced an O(N*C) loop that encoded every single column name to a hex string just to find an edge handle match with an O(1) decoding approach followed by a simple O(N) existence check. This improves export generation performance significantly for large ERD schemas.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4b1a9eba-0b43-4872-a5e7-d02bd3f19259

📥 Commits

Reviewing files that changed from the base of the PR and between 72afe6d and 5bf0590.

📒 Files selected for processing (4)
  • .jules/bolt.md
  • frontend/src/erd/export.ts
  • frontend/src/erd/handleUtils.test.ts
  • frontend/src/erd/handleUtils.ts

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

Superseded by #700, which carries the canonical strict handle decoder, Unicode and malformed-input contracts, and the full export-path integration. Closing this narrower duplicate prevents two incompatible handle utility APIs from landing independently.

@seonghobae seonghobae closed this Aug 5, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded by #700, which carries the canonical strict handle decoder, Unicode and malformed-input contracts, and the full export-path integration. Closing this narrower duplicate prevents two incompatible handle utility APIs from landing independently.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant