fix: align eager, lazy, and LCP image hints with HTML standard - #141
fix: align eager, lazy, and LCP image hints with HTML standard#141seonghobae wants to merge 5 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
📝 WalkthroughWalkthrough홈페이지 이미지 렌더링 힌트 계약을 정리했습니다. eager 이미지는 기본 Changes이미지 렌더링 힌트
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
What
decoding="async"from eager first-viewport images and the single declared LCP candidate, leaving the standards-defined missing-value default (auto) to the user agent.decoding="async"for explicitly lazy-loaded images.docs/doctoring/image-rendering-hints.md.Why
The HTML Living Standard defines
decodingas a preference hint whose missing-value default isauto. It does not guarantee a main-thread or background-thread execution path.fetchpriorityindependently influences fetch priority. This PR therefore avoids claiming that removingdecoding="async"alone universally improves LCP.Verification required at the exact current head
python3 -m pytest tests/References
This PR supersedes the stale duplicate #100 by carrying forward its valid standards reasoning and stronger non-vacuous tests on the current base.
Summary by CodeRabbit
성능 개선
문서
테스트