fix: align eager, lazy, and LCP image hints with HTML standard - #100
fix: align eager, lazy, and LCP image hints with HTML standard#100seonghobae wants to merge 7 commits into
Conversation
- Remove `decoding="async"` from critical SVG images in `index.html` - Update `test_styles.py` to expect async decoding only on lazy-loaded images - Update `.jules/bolt.md` and `CHANGELOG.md`
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR optimizes LCP for the static homepage by removing decoding="async" from above-the-fold SVG images (logo + hero), and updates the regression test to apply the async-decoding rule only to lazy-loaded images.
Changes:
- Remove
decoding="async"from the header logo SVG and hero SVG to avoid delaying LCP rendering. - Update
tests/test_styles.pyto validatedecoding="async"only forloading="lazy"images. - Document the change in
CHANGELOG.mdand record the performance learning in.jules/bolt.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
index.html |
Removes async decoding on LCP/above-the-fold SVGs while keeping async decoding on lazy-loaded images. |
tests/test_styles.py |
Narrows the async-decoding assertion to lazy-loaded images. |
CHANGELOG.md |
Adds an Unreleased entry for the LCP optimization. |
.jules/bolt.md |
Adds a performance journal entry capturing the new rule of thumb for LCP images. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Warning Review limit reached
Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Comment |
|
Closing as superseded by #141. The current-base PR now carries forward this PR's valid standards reasoning, non-vacuous eager/lazy/LCP image contracts, bounded performance claims, and APA 7th doctoring references without the stale-base and unrelated-history conflicts present here. No unique required change remains in this branch. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
What
fetchpriority="high"LCP 후보에서 강제decoding="async"를 제거해 사용자 에이전트의 표준 기본값auto에 맡깁니다.loading="lazy"이미지에는decoding="async"를 유지합니다.Why
decoding은 이미지 표시 방식에 관한 선호 힌트이고, 속성이 없으면auto입니다.fetchpriority는 별도의 fetch 우선순위 힌트입니다. 따라서 SVG에 디코딩이 없다고 가정하거나 속성 제거만으로 LCP 개선을 단정하지 않고, 중요한 이미지는 브라우저 판단에 맡기며 fetch 우선순위 계약을 독립적으로 검증합니다.Verification
python3 -m pytest tests/References
이 PR은 동일 목적의 #81, #89, #92, #95, #98을 통합하는 canonical PR입니다.