Skip to content

fix: align eager, lazy, and LCP image hints with HTML standard - #100

Closed
seonghobae wants to merge 7 commits into
mainfrom
feature/bolt-lcp-optimization-2587083072321749037
Closed

fix: align eager, lazy, and LCP image hints with HTML standard#100
seonghobae wants to merge 7 commits into
mainfrom
feature/bolt-lcp-optimization-2587083072321749037

Conversation

@seonghobae

@seonghobae seonghobae commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

What

  • 첫 화면의 eager 이미지와 유일한 fetchpriority="high" LCP 후보에서 강제 decoding="async"를 제거해 사용자 에이전트의 표준 기본값 auto에 맡깁니다.
  • 명시적인 loading="lazy" 이미지에는 decoding="async"를 유지합니다.
  • eager, lazy, LCP 집합의 존재와 힌트 조합을 각각 검증하여 vacuous pass를 차단합니다.
  • HTML Living Standard와 Fetch Priority 공식 문서를 APA 7th 형식으로 성능 doctoring 문서에 기록합니다.

Why

decoding은 이미지 표시 방식에 관한 선호 힌트이고, 속성이 없으면 auto입니다. fetchpriority는 별도의 fetch 우선순위 힌트입니다. 따라서 SVG에 디코딩이 없다고 가정하거나 속성 제거만으로 LCP 개선을 단정하지 않고, 중요한 이미지는 브라우저 판단에 맡기며 fetch 우선순위 계약을 독립적으로 검증합니다.

Verification

  • python3 -m pytest tests/
  • exact current head의 보안·정적 분석·리뷰·필수 checks
  • 배포 후 LCP 실측은 별도 관측 대상으로 유지

References

  • WHATWG. (2026, July 20). HTML standard: The img element.
  • Osmani, A., Sohoni, L., Meenan, P., & Pollard, B. (2023, November 14). Optimize resource loading with the Fetch Priority API. web.dev.

이 PR은 동일 목적의 #81, #89, #92, #95, #98을 통합하는 canonical PR입니다.

- Remove `decoding="async"` from critical SVG images in `index.html`
- Update `test_styles.py` to expect async decoding only on lazy-loaded images
- Update `.jules/bolt.md` and `CHANGELOG.md`
Copilot AI review requested due to automatic review settings July 23, 2026 14:08
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes LCP for the static homepage by removing decoding="async" from above-the-fold SVG images (logo + hero), and updates the regression test to apply the async-decoding rule only to lazy-loaded images.

Changes:

  • Remove decoding="async" from the header logo SVG and hero SVG to avoid delaying LCP rendering.
  • Update tests/test_styles.py to validate decoding="async" only for loading="lazy" images.
  • Document the change in CHANGELOG.md and record the performance learning in .jules/bolt.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
index.html Removes async decoding on LCP/above-the-fold SVGs while keeping async decoding on lazy-loaded images.
tests/test_styles.py Narrows the async-decoding assertion to lazy-loaded images.
CHANGELOG.md Adds an Unreleased entry for the LCP optimization.
.jules/bolt.md Adds a performance journal entry capturing the new rule of thumb for LCP images.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_styles.py Outdated
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 16b64fe2-bd00-4b34-b889-9a4a57ce1ab3

📥 Commits

Reviewing files that changed from the base of the PR and between d06c1cb and fa518c4.

📒 Files selected for processing (4)
  • .jules/bolt.md
  • CHANGELOG.md
  • index.html
  • tests/test_styles.py

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae changed the title ⚡ Bolt: [성능 개선 LCP 최적화] fix: align eager, lazy, and LCP image hints with HTML standard Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #141. The current-base PR now carries forward this PR's valid standards reasoning, non-vacuous eager/lazy/LCP image contracts, bounded performance claims, and APA 7th doctoring references without the stale-base and unrelated-history conflicts present here. No unique required change remains in this branch.

@seonghobae seonghobae closed this Aug 5, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #141. The current-base PR now carries forward this PR's valid standards reasoning, non-vacuous eager/lazy/LCP image contracts, bounded performance claims, and APA 7th doctoring references without the stale-base and unrelated-history conflicts present here. No unique required change remains in this branch.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants