Skip to content

Refactor buffer management and update configuration handling - #456

Closed
KeithWiles wants to merge 19 commits into
CloudNativeDataPlane:mainfrom
KeithWiles:mbuf-build-updates
Closed

Refactor buffer management and update configuration handling#456
KeithWiles wants to merge 19 commits into
CloudNativeDataPlane:mainfrom
KeithWiles:mbuf-build-updates

Conversation

@KeithWiles

@KeithWiles KeithWiles commented Feb 24, 2026

Copy link
Copy Markdown
Contributor
  • Added support for unaligned buffers in the buffer management structure.
  • Renamed buffer management functions and updated their signatures to use mbuf_t for better type safety.
  • Updated the parsing of JSON configuration to include a new option for unaligned buffers.
  • Changed the handling of buffer sizes and headroom to improve clarity and consistency.
  • Modified the xskdev interface to accommodate the new buffer management structure and functions.
  • Improved error handling and logging for buffer management operations.
  • The uintr file needs '-mtls-dialect-gnu2' to build the uintr_handler.c file.

@KeithWiles
KeithWiles requested a review from Copilot February 24, 2026 15:23

This comment was marked as outdated.

Sign in to view

@KeithWiles
KeithWiles requested a review from Copilot February 24, 2026 16:39

This comment was marked as outdated.

Sign in to view

@KeithWiles
KeithWiles requested a review from Copilot February 24, 2026 17:10

This comment was marked as outdated.

Sign in to view

@KeithWiles
KeithWiles requested a review from Copilot February 24, 2026 17:47

This comment was marked as outdated.

Sign in to view

@KeithWiles
KeithWiles requested a review from Copilot February 24, 2026 19:07
Copilot AI reviewed Feb 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread doc/guides/prog_guide/xskdev_buffer_mgmt.rst Outdated
Comment thread doc/guides/prog_guide/xskdev_buffer_mgmt.rst Outdated
Comment thread examples/cndpfwd/main.c Outdated
Comment thread lib/core/xskdev/xskdev.h Outdated
Comment thread examples/cndpfwd/main.c
Comment thread lib/core/xskdev/xskdev.h Outdated
Comment thread lib/core/xskdev/xskdev.h Outdated
@KeithWiles
Refactor buffer management and update configuration handling
d1fcbf5 
- Added support for unaligned buffers in the buffer management structure.
- Renamed buffer management functions and updated their signatures to use mbuf_t for better type safety.
- Updated the parsing of JSON configuration to include a new option for unaligned buffers.
- Changed the handling of buffer sizes and headroom to improve clarity and consistency.
- Modified the xskdev interface to accommodate the new buffer management structure and functions.
- Improved error handling and logging for buffer management operations.
- The uintr file needs '-mtls-dialect-gnu2' to build the uintr_handler.c file.

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@KeithWiles
KeithWiles marked this pull request as draft February 24, 2026 19:48
@KeithWiles
KeithWiles requested a review from Copilot May 5, 2026 12:46
Copilot AI reviewed May 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/core/xskdev/xskdev.c Outdated
Comment thread examples/cndpfwd/main.c
Comment thread lib/core/xskdev/xskdev.h
Comment thread lib/include/cne_lport.h
Comment thread tools/cne-build.sh Outdated
Comment thread examples/cndpfwd/parse-args.c
pre-commit-ci Bot and others added 8 commits May 5, 2026 08:14
@pre-commit-ci @KeithWiles
[pre-commit.ci] pre-commit autoupdate
4db75ee 
updates:
- [github.com/pre-commit/mirrors-clang-format: v21.1.8 → v22.1.0](pre-commit/mirrors-clang-format@v21.1.8...v22.1.0)

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@dependabot @KeithWiles
build(deps): bump actions/upload-artifact in the github-actions group
12c2373 
Bumps the github-actions group with 1 update: [actions/upload-artifact](https://github.com/actions/upload-artifact).

Updates `actions/upload-artifact` from 6 to 7
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v6...v7)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@pre-commit-ci @KeithWiles
[pre-commit.ci] pre-commit autoupdate
e81373e 
updates:
- [github.com/codespell-project/codespell: v2.4.1 → v2.4.2](codespell-project/codespell@v2.4.1...v2.4.2)

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@dependabot @KeithWiles
build(deps): bump the github-actions group with 2 updates
a62e8af 
Bumps the github-actions group with 2 updates: [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) and [docker/build-push-action](https://github.com/docker/build-push-action).

Updates `docker/setup-buildx-action` from 3 to 4
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@v3...v4)

Updates `docker/build-push-action` from 6 to 7
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v6...v7)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: docker/build-push-action
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@pre-commit-ci @KeithWiles
[pre-commit.ci] pre-commit autoupdate
8cb0171 
updates:
- [github.com/pre-commit/mirrors-clang-format: v22.1.0 → v22.1.1](pre-commit/mirrors-clang-format@v22.1.0...v22.1.1)

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@pre-commit-ci @KeithWiles
[pre-commit.ci] pre-commit autoupdate
cfc11d3 
updates:
- [github.com/pre-commit/mirrors-clang-format: v22.1.1 → v22.1.2](pre-commit/mirrors-clang-format@v22.1.1...v22.1.2)

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@dependabot @KeithWiles
build(deps): bump fedora in /containerization/docker/fedora
212965a 
Bumps fedora from 43 to 44.

---
updated-dependencies:
- dependency-name: fedora
  dependency-version: '44'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@pre-commit-ci @KeithWiles
[pre-commit.ci] pre-commit autoupdate
8bd1a99 
updates:
- [github.com/pre-commit/mirrors-clang-format: v22.1.2 → v22.1.4](pre-commit/mirrors-clang-format@v22.1.2...v22.1.4)

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
KeithWiles and others added 3 commits May 5, 2026 08:14
@KeithWiles
Potential fix for pull request finding
eee3d22 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@dependabot @KeithWiles
build(deps): bump pygments from 2.15.0 to 2.20.0 in /tools
af9945a 
Bumps [pygments](https://github.com/pygments/pygments) from 2.15.0 to 2.20.0.
- [Release notes](https://github.com/pygments/pygments/releases)
- [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES)
- [Commits](pygments/pygments@2.15.0...2.20.0)

---
updated-dependencies:
- dependency-name: pygments
  dependency-version: 2.20.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@KeithWiles
fix typos
627fddc 
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@KeithWiles
KeithWiles force-pushed the mbuf-build-updates branch from abae485 to 627fddc Compare May 5, 2026 13:15
KeithWiles and others added 3 commits May 5, 2026 08:16
@KeithWiles
Merge branch 'main' into mbuf-build-updates
6fc699b
@KeithWiles
style: format code for better readability in multiple files
e942bda 
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@KeithWiles
style: improve script documentation and formatting in cne-build.sh
6e36142 
Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
Copilot AI mentioned this pull request May 5, 2026
Merged
Copilot AI added a commit that referenced this pull request May 5, 2026
@KeithWiles
Apply PR #456 changes with pre-commit fixes (clang-format, trailing w…
7ec40b7 
…hitespace, etc.)

Agent-Logs-Url: https://github.com/CloudNativeDataPlane/cndp/sessions/baaa5339-1235-465f-a363-3f1c7b95fd75

Co-authored-by: KeithWiles <86847941+KeithWiles@users.noreply.github.com>
KeithWiles added a commit that referenced this pull request May 5, 2026
@KeithWiles
Apply PR #456 changes with pre-commit fixes (clang-format, trailing w…
29b4e47 
…hitespace, etc.)

Agent-Logs-Url: https://github.com/CloudNativeDataPlane/cndp/sessions/baaa5339-1235-465f-a363-3f1c7b95fd75

Co-authored-by: KeithWiles <86847941+KeithWiles@users.noreply.github.com>
@KeithWiles
KeithWiles marked this pull request as ready for review May 5, 2026 14:35
@KeithWiles

KeithWiles commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

@copilot why can I not merge this branch?

@KeithWiles
refactor: change char pointers to const char in multiple files for be…
ef59597 
…tter type safety

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
@KeithWiles KeithWiles closed this May 5, 2026
@KeithWiles
KeithWiles deleted the mbuf-build-updates branch May 5, 2026 16:16
@KeithWiles
KeithWiles restored the mbuf-build-updates branch May 5, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KeithWiles