Skip to content

Fix pre-commit.ci clang-format failures from PR #456 buffer management refactor - #467

Merged
KeithWiles merged 2 commits into
mainfrom
copilot/fix-pre-commit-ci-validation
May 5, 2026
Merged

Fix pre-commit.ci clang-format failures from PR #456 buffer management refactor#467
KeithWiles merged 2 commits into
mainfrom
copilot/fix-pre-commit-ci-validation

Conversation

Copilot AI commented May 5, 2026

Copy link
Copy Markdown
Contributor

PR #456 introduced buffer management and xskdev refactoring that repeatedly failed pre-commit.ci due to clang-format violations. The PR author's latest commit resolved these, and this PR carries those fixes forward.

Clang-format fixes applied to

  • lib/core/pktmbuf/pktmbuf_offload.h — enum value alignment
  • lib/core/xskdev/xskdev.c — variable alignment in fq_add()
  • lib/include/cne_lport.h#define macro alignment
  • lib/usr/clib/dsa/cne_dsa.c — designated initializer alignment
  • lib/usr/clib/utils/crc32.c — continuation line alignment
  • test/testcne/acl_test_data.h — inline comment alignment

Substantive changes (from PR #456 HEAD)

  • lib/core/pktmbuf/, lib/core/xskdev/, lib/include/cne_lport.h — buffer mgmt struct refactored to use mbuf_t typed callbacks; buf_headroom/buf_arg reorganized; unaligned_buff flag removed (unaligned path driven by LPORT_UMEM_UNALIGNED_BUFFERS flag)
  • lib/usr/app/jcfg/ — parses new unaligned_buffers lport JSON key → LPORT_UMEM_UNALIGNED_BUFFERS
  • lib/usr/slib/ibroker/meson.build — splits uintr_handler.c into a separate static lib built with -mtls-dialect=gnu2 to satisfy toolchain requirements
  • examples/cndpfwd/ — replaces static frame bytes with proper RFC-conformant UDP/IP header construction
  • tools/cne-build.sh — array-based meson args, improved quoting, minor message wording
Original prompt

Fix the pre-commit.ci validation failure for pull request #456 in repository CloudNativeDataPlane/cndp.

Context:

Task:

  1. Inspect the pull request changes and determine why pre-commit.ci is failing.
  2. Make the minimal code or formatting changes required to satisfy the pre-commit hooks.
  3. Ensure the fix is limited to resolving the pre-commit.ci validation problem and does not introduce unrelated changes.
  4. Open a pull request with the fix.

Notes:

  • Use the existing repository and relevant branch context from PR Refactor buffer management and update configuration handling #456.
  • If the failure is caused by formatting, linting, whitespace, YAML/TOML formatting, end-of-file newlines, or similar pre-commit hook issues, apply the canonical fix expected by pre-commit.
  • If the failure is caused by a repository-specific hook, update the affected files accordingly.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Fix the pre-commit.ci problem when validating the PR changes

Assistant: I’m waiting for your response to the approval dialog so I can continue fixing the pre-commit validation issue on that PR.

This pull request was created from Copilot chat.

…hitespace, etc.)

Agent-Logs-Url: https://github.com/CloudNativeDataPlane/cndp/sessions/baaa5339-1235-465f-a363-3f1c7b95fd75

Co-authored-by: KeithWiles <86847941+KeithWiles@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix pre-commit.ci validation failure for PR #456 Fix pre-commit.ci clang-format failures from PR #456 buffer management refactor May 5, 2026
Copilot AI requested a review from KeithWiles May 5, 2026 14:29
@KeithWiles
KeithWiles marked this pull request as ready for review May 5, 2026 14:31
@KeithWiles
KeithWiles merged commit 29b4e47 into main May 5, 2026
6 of 7 checks passed
@KeithWiles
KeithWiles deleted the copilot/fix-pre-commit-ci-validation branch May 5, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants