Fix pre-commit.ci clang-format failures from PR #456 buffer management refactor - #467
Merged
Merged
Conversation
…hitespace, etc.) Agent-Logs-Url: https://github.com/CloudNativeDataPlane/cndp/sessions/baaa5339-1235-465f-a363-3f1c7b95fd75 Co-authored-by: KeithWiles <86847941+KeithWiles@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix pre-commit.ci validation failure for PR #456
Fix pre-commit.ci clang-format failures from PR #456 buffer management refactor
May 5, 2026
KeithWiles
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #456 introduced buffer management and xskdev refactoring that repeatedly failed pre-commit.ci due to clang-format violations. The PR author's latest commit resolved these, and this PR carries those fixes forward.
Clang-format fixes applied to
lib/core/pktmbuf/pktmbuf_offload.h— enum value alignmentlib/core/xskdev/xskdev.c— variable alignment infq_add()lib/include/cne_lport.h—#definemacro alignmentlib/usr/clib/dsa/cne_dsa.c— designated initializer alignmentlib/usr/clib/utils/crc32.c— continuation line alignmenttest/testcne/acl_test_data.h— inline comment alignmentSubstantive changes (from PR #456 HEAD)
lib/core/pktmbuf/,lib/core/xskdev/,lib/include/cne_lport.h— buffer mgmt struct refactored to usembuf_ttyped callbacks;buf_headroom/buf_argreorganized;unaligned_buffflag removed (unaligned path driven byLPORT_UMEM_UNALIGNED_BUFFERSflag)lib/usr/app/jcfg/— parses newunaligned_bufferslport JSON key →LPORT_UMEM_UNALIGNED_BUFFERSlib/usr/slib/ibroker/meson.build— splitsuintr_handler.cinto a separate static lib built with-mtls-dialect=gnu2to satisfy toolchain requirementsexamples/cndpfwd/— replaces static frame bytes with proper RFC-conformant UDP/IP header constructiontools/cne-build.sh— array-based meson args, improved quoting, minor message wordingOriginal prompt
This pull request was created from Copilot chat.