Fix PolylineGlowMaterial rendering issue on Ubuntu (#13632)#13633
Merged
mzschwartz5 merged 2 commits intoJul 20, 2026
Conversation
Contributor
|
Thank you for the pull request, @cyzhao-dad! Welcome to the Cesium community! In order for us to review your PR, please complete the following steps:
Review Pull Request Guidelines to make sure your PR gets accepted quickly. |
Fixed incorrect clamp function argument order in PolylineGlowMaterial shader. The original code used clamp(0.0, 1.0, glow) instead of clamp(glow, 0.0, 1.0), which caused the alpha value to always be 1.0 regardless of the glow intensity. This fixes the rendering issue where PolylineGlowMaterial did not display correctly on Ubuntu systems. Signed-off-by: zhaochen <453157936@qq.com>
cyzhao-dad
force-pushed
the
fix/glow-material-linux-edge
branch
from
July 17, 2026 05:10
b1c326c to
56ed93a
Compare
Signed-off-by: zhaochen <453157936@qq.com>
Contributor
|
Hi @cyzhao-dad - thank you for the contribution! If you can sign the Contributor License Agreement, I'll approve the GitHub actions to run and we can get this merged when they pass. Also, in the meantime, can you please fill out the description of this PR - add testing instructions (an example sandcastle would be ideal), link an issue if there is one, and fill in the AI acknowledgement. |
Contributor
|
Probably supposed to fix #13632 |
Contributor
Author
|
this is ready |
mzschwartz5
approved these changes
Jul 20, 2026
mzschwartz5
left a comment
mzschwartz5
left a comment
Contributor
There was a problem hiding this comment.
LGTM - thanks again @cyzhao-dad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13632
Description
Fixed an error in the usage of the
clampfunction inPolylineGlowMaterialshader: the parameter order was incorrect (clamp(0.0, 1.0, glow)instead ofclamp(glow, 0.0, 1.0)), which caused the alpha value to always be1.0regardless of the glow intensity. This fixes the rendering issue wherePolylineGlowMaterialdid not display correctly on Ubuntu systems.Issue link: #13632
Testing Done
Sandcastle example
The existing Sandcastle example
polylinecan be used to verify the fix:packages/sandcastle/gallery/polyline/main.jsglowingLineentity usesPolylineGlowMaterialPropertywithglowPower: 0.2,taperPower: 0.5,color: Cesium.Color.CORNFLOWERBLUE.Steps to reproduce and verify
polylineexample on Ubuntu before the fix → the glowing blue line renders incorrectly (alpha is always 1.0, glow effect is lost).ESLint & unit tests
AI Compliance
Signed-off-by: zhaochen 453157936@qq.com