Skip to content
This repository was archived by the owner on Apr 14, 2026. It is now read-only.

[Feature] Changes needed for reviews#465

Merged
jamescdavis merged 36 commits into
developfrom
feature/reviews
Oct 24, 2017
Merged

[Feature] Changes needed for reviews#465
jamescdavis merged 36 commits into
developfrom
feature/reviews

Conversation

@aaxelb

@aaxelb aaxelb commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

Replaces #454

Purpose

Changes to preprint submission and detail pages to support OSF Reviews.

NOTE: Should not be merged until after the ember-osf PR is released and the dependency here is updated.

Sister PRs:
CenterForOpenScience/ember-osf#272
CenterForOpenScience/osf.io#7708

Changes

Preprint detail page

Add a status banner to the preprint detail page, visible only to node admins and contributors.

screen shot 2017-08-10 at 1 58 45 pm
screen shot 2017-08-10 at 2 06 35 pm
screen shot 2017-08-10 at 2 08 21 pm
screen shot 2017-08-10 at 2 17 56 pm
screen shot 2017-08-11 at 4 39 44 pm
screen shot 2017-08-14 at 10 19 25 am

Preprint create/submit/edit page

Update language at the top, change title depending on provider workflow.

screen shot 2017-08-17 at 3 15 33 pm
screen shot 2017-08-17 at 3 15 46 pm
screen shot 2017-08-17 at 3 17 26 pm

Change language at the bottom and submission behavior, depending on provider workflow.

screen shot 2017-08-17 at 3 15 02 pm
screen shot 2017-08-17 at 3 15 58 pm
screen shot 2017-08-18 at 10 36 23 am

Side effects

laurenbarker and others added 27 commits September 14, 2017 15:20
* Add pending status banner to preprint detail page

* Add moderator feedback dropdown

* Add aria labels

* Use fat arrows and objects
* Remove submission block

* Add logs on submit/resubmit

* Expect null from reviewsWorkflow

Make permission information language match

* Assume API will lowercase values

Fix typos

* Chain save events

Use firstObject

Move promise to afterModel

* Don't request the log unless comments are visible
* Don't show errors until user clicks submit

* Update test and action name
[MOD-92][Feature] Update ember-osf commit
[MOD-84][MOD-123] Handle preprints with no actions
* Show status banner to contributors

* User currentUser.currentUserId

Fix sending to keen

@jamescdavis jamescdavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Ready to merge!

@jamescdavis
jamescdavis merged commit 8ae3a57 into develop Oct 24, 2017
@jamescdavis
jamescdavis deleted the feature/reviews branch November 28, 2018 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants