Skip to content
This repository was archived by the owner on Apr 14, 2026. It is now read-only.

[Feature] Changes needed for reviews#454

Closed
aaxelb wants to merge 22 commits into
CenterForOpenScience:developfrom
aaxelb:feature/reviews
Closed

[Feature] Changes needed for reviews#454
aaxelb wants to merge 22 commits into
CenterForOpenScience:developfrom
aaxelb:feature/reviews

Conversation

@aaxelb

@aaxelb aaxelb commented Sep 14, 2017

Copy link
Copy Markdown
Contributor

Purpose

Changes to preprint submission and detail pages to support OSF Reviews.

Sister PRs:
CenterForOpenScience/ember-osf#272
CenterForOpenScience/osf.io#7708

Changes

Preprint detail page

Add a status banner to the preprint detail page, visible only to node admins.

screen shot 2017-08-10 at 1 58 45 pm
screen shot 2017-08-10 at 2 06 35 pm
screen shot 2017-08-10 at 2 08 21 pm
screen shot 2017-08-10 at 2 17 56 pm
screen shot 2017-08-11 at 4 39 44 pm
screen shot 2017-08-14 at 10 19 25 am

Preprint create/submit/edit page

Update language at the top, change title depending on provider workflow.

screen shot 2017-08-17 at 3 15 33 pm
screen shot 2017-08-17 at 3 15 46 pm
screen shot 2017-08-17 at 3 17 26 pm

Change language at the bottom and submission behavior, depending on provider workflow.

screen shot 2017-08-17 at 3 15 02 pm
screen shot 2017-08-17 at 3 15 58 pm
screen shot 2017-08-18 at 10 36 23 am

Side effects

laurenbarker and others added 4 commits September 14, 2017 15:20
* Add pending status banner to preprint detail page

* Add moderator feedback dropdown

* Add aria labels

* Use fat arrows and objects
* Remove submission block

* Add logs on submit/resubmit

* Expect null from reviewsWorkflow

Make permission information language match

* Assume API will lowercase values

Fix typos

* Chain save events

Use firstObject

Move promise to afterModel

* Don't request the log unless comments are visible
@aaxelb aaxelb changed the title [WIP][Feature] Changes needed for reviews [Feature] Changes needed for reviews Sep 15, 2017
@aaxelb

aaxelb commented Oct 12, 2017

Copy link
Copy Markdown
Contributor Author

Closed in favor of #465

@aaxelb aaxelb closed this Oct 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants