Skip to content

remove teehr automated eval from datastreamcli - #113

Open
JordanLaserGit wants to merge 1 commit into
mainfrom
remove_teehr_eval
Open

remove teehr automated eval from datastreamcli#113
JordanLaserGit wants to merge 1 commit into
mainfrom
remove_teehr_eval

Conversation

@JordanLaserGit

@JordanLaserGit JordanLaserGit commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

The docker container ngiab-teehr is unmaintained and is now dysfunctional against the existing state of this code base. This docker container is neccessary for the stability of the -E,EVAL feature so, this PR removes the automated TEEHR eval from datastreamcli.

Also, while retrospective simulations are possible with datastreamcli, the integrated forcingprocessor is optimized for VPU scale forecast simulations, not the smaller scale retrospective simulations that researchers then want to evaluate.

Additions

  • None

Removals

  • EVAL feature

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@JordanLaserGit JordanLaserGit self-assigned this Aug 11, 2026
@JordanLaserGit JordanLaserGit added bug Something isn't working P1 Priority level. P0: Critical, P1: High, P2: Medium, P3: Low labels Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working P1 Priority level. P0: Critical, P1: High, P2: Medium, P3: Low

Projects

Development

Successfully merging this pull request may close these issues.

2 participants