Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(sync): rebuild wff-code/wff-chat from .claude@d4bda2a #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
chore(sync): rebuild wff-code/wff-chat from .claude@d4bda2a #8
Changes from all commits
1820d44File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Scope the GitHub Code Security billing claim to private and internal repositories.
The existing
#VERIFYinstruction requires checking each repository’s actual entitlement before treating a live dependency-review or CodeQL step as a non-finding. Keep that instruction unchanged.In both
ci-fix/SKILL.mdfiles, state that GitHub Code Security is required for these features in private and internal repositories. Public repositories can use dependency review and CodeQL without paid GitHub Code Security. Keep the fleet-wide removal statement, but identify it as a fleet policy decision rather than a universal GitHub limitation.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: ByronWilliamsCPA/plugin
Length of output: 286
🏁 Script executed:
Repository: ByronWilliamsCPA/plugin
Length of output: 33292
🏁 Script executed:
Repository: ByronWilliamsCPA/plugin
Length of output: 9008
🌐 Web query:
site:github.com/github/codeql-action upload-sarif security-events write sarif_file continue-on-error documentation💡 Result:
The upload-sarif GitHub Action is used to upload static analysis results (in SARIF format) to GitHub code scanning. Below is the technical breakdown regarding your query: Permissions: To use the upload-sarif action, your workflow must have the security-events: write permission [1][2][3]. Without this, the action will typically fail with a 404 Not Found error (Resource not accessible by integration) [2][3]. You must explicitly define this in your workflow file, usually at the job level [2][3]: permissions: security-events: write Inputs: The primary input is sarif_file, which specifies the path to the SARIF file or a directory of SARIF files [1]. While there is a token input, it is generally recommended to avoid providing it and allow the action to use the built-in GITHUB_TOKEN automatically, provided the correct permissions are set in the workflow [1][4]. Continue-on-error: There is no direct continue-on-error input parameter for the upload-sarif action itself [1]. If you want to prevent a workflow from failing when the upload-sarif step encounters an error, you must use the standard GitHub Actions continue-on-error property on the step: - name: Upload SARIF uses: github/codeql-action/upload-sarif@v3 continue-on-error: true with: sarif_file: results.sarif Note that the action internally includes a wait-for-processing input (default: true), which controls whether the action blocks the workflow until the SARIF file has been processed by GitHub code scanning [1][5]. While the action has mechanisms to handle various upload errors, setting continue-on-error: true will allow your workflow to proceed regardless of whether the SARIF upload succeeds or fails [1].
Citations:
Validate effective SARIF ingestion.
The rule checks only for an
upload-sarifstep and a generated file path. It should also validate the effectivesecurity-events: writepermission, exactsarif_file, step conditions, and failure propagation. Otherwise, the Security tab can remain empty whileactions/upload-artifactstores the raw file.🧰 Tools
🪛 LanguageTool
[uncategorized] ~1276-~1276: The official name of this software platform is spelled with a capital “H”.
Context: ...s Grype and OSV-Scanner jobs still call
github/codeql-action/upload-sarifto ingest i...(GITHUB)
[uncategorized] ~1276-~1276: The official name of this software platform is spelled with a capital “H”.
Context: ...ps
,osv-sbom-runtime-deps), matching.github/workflows/README.md:120-129`. Verify th...(GITHUB)
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: ByronWilliamsCPA/plugin
Length of output: 275
🏁 Script executed:
Repository: ByronWilliamsCPA/plugin
Length of output: 21819
🏁 Script executed:
Repository: ByronWilliamsCPA/plugin
Length of output: 24068
🏁 Script executed:
Repository: ByronWilliamsCPA/plugin
Length of output: 13667
Classify orphan checks by producer, including dependency review.
This section states that
dependency-review.ymlwas deleted but only classifiesCodeQLdisplay names as orphaned. ADependency reviewcontext is not covered. Before applying the orphan rule, identify the active producer and confirm the repository’s GHAS entitlement, including CodeQL Default setup.🧰 Tools
🪛 LanguageTool
[style] ~1625-~1625: The double modal “requires paid” is nonstandard (only accepted in certain dialects). Consider “to be paid”.
Context: .../dependency-review-action` now requires paid GitHub Advanced Security). A "CodeQL" o...
(NEEDS_FIXED)
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: ByronWilliamsCPA/plugin
Length of output: 203
🏁 Script executed:
Repository: ByronWilliamsCPA/plugin
Length of output: 40870
Do not classify a queued SARIF check as non-blocking from
mergeablealone.mergeable: MERGEABLEdoes not establish that the check is absent from required status contexts. CheckmergeStateStatusand required-context membership first. State that the PR is safe to merge only when those checks show that the queued SARIF check does not block the merge.🤖 Prompt for AI Agents