Skip to content

Fix AMQP compilation on Android #6740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antkmsft merged 1 commit into from
Sep 16, 2025
Merged

Fix AMQP compilation on Android #6740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions sdk/core/azure-core-amqp/src/impl/uamqp/amqp/claim_based_security.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
#include <azure/core/diagnostics/logger.hpp>
#include <azure/core/internal/diagnostics/log.hpp>

#include <type_traits>

using namespace Azure::Core::Diagnostics::_internal;
using namespace Azure::Core::Diagnostics;
using namespace Azure::Core::Amqp::_internal;
Expand Down Expand Up @@ -67,9 +69,19 @@ namespace Azure { namespace Core { namespace Amqp { namespace _detail {
message.SetBody(static_cast<Models::AmqpValue>(token));

message.ApplicationProperties["name"] = static_cast<Models::AmqpValue>(audience);
message.ApplicationProperties["expiration"]
= std::chrono::duration_cast<std::chrono::seconds>(tokenExpirationTime.time_since_epoch())
.count();

// It appears that on Android, if you get a "long long" (from std::chrono::seconds::count()) and
// try to pass it to the set of overloads of AmqpValue() which do exist for all the range of
// fixed bit integers, including int64_t and uint64_t, it is still ambiguous for the compiler
// which overload to choose, as if "std::u?int*_t" were not typedefs, but some custom types.
Comment thread
antkmsft marked this conversation as resolved.
static_assert(
std::is_signed<std::chrono::seconds::rep>::value
&& std::is_integral<std::chrono::seconds::rep>::value
&& sizeof(std::chrono::seconds::rep) <= sizeof(std::int64_t),
"std::chrono::seconds::rep is expected to fit into std::int64_t");
message.ApplicationProperties["expiration"] = static_cast<std::int64_t>(
std::chrono::duration_cast<std::chrono::seconds>(tokenExpirationTime.time_since_epoch())
.count());

auto result = m_management->ExecuteOperation(
"put-token",
Expand Down