Fix AMQP compilation on Android#6740
Merged
Merged
Conversation
antkmsft
added
Azure.Core
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes AMQP compilation issues on Android by resolving ambiguous type conversion when passing chrono duration values to AmqpValue constructors. The change addresses a compiler ambiguity where Android's compiler cannot determine which AmqpValue overload to use for std::chrono::seconds::count() return values.
- Added explicit cast to
std::int64_tfor chrono duration count values - Added compile-time assertions to validate type assumptions
- Included
<type_traits>header for static assertion support
LarryOsterman
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix daily vcpkg validation PR, similar to #6738.
It should be the final PR to make the vcpkg validation PR green (FWIW, with this change I was able to compile core-amqp in vcpkg for android locally).