fix(model): allowlist chat history message roles - #41
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
Reject non-OpenAI roles before append so poison/buggy callers cannot inject arbitrary roles into ChatCompletion history. Signed-off-by: Bartok <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
system/user/assistant/function/tool) before append.Motivation
add_message_to_historypreviously stuffed any role string into history. A poisoned or buggy caller could inject non-OpenAI roles into subsequent ChatCompletion calls.Differential note
Concurrent #40 (Claim: bartok) covers history directory ensure/mkdir. This PR is orthogonal (roles only). Left #40 alone.
Changes
llm_model/llm_model/chat_role_sanitize.pyChatGPTNode.add_message_to_historyllm_model/test/test_chat_role_sanitize.pyVerification
PYTHONPATH=llm_model python3 -m unittest discover -s llm_model/test -p 'test_chat_role_sanitize.py' -v— 2 passed (8 asserts)Notes
AI-assisted; human-reviewed. Pivot from abandoned home-confinement plan after concurrent #40.
Agent-Owner:
sera· Platform: hermes · Claim-TTL: 24h