fix(model): coerce None OpenAI content before String publish - #39
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
Function-call choices often set message content to None; assigning that to std_msgs/String.data is unsafe. Normalize to a string at the response boundary and inside publish_string. Offline unit tests included. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAI function-call responses often set
message.contenttoNone. Feeding that intostd_msgs/msg/String.data(or logging paths that assume a string) is unsafe.This change:
normalize_openai_text()pure helperpublish_stringso publishers never receiveNoneNonefunction_callfieldMotivation
Defensive fix for a real crash path when the model chooses a tool/function call over plain text feedback.
Verification
AI-assisted scope; human-reviewed before open.
Claim: bartok
Operator: bartok
Campaign: aerial-drone