Skip to content

fix(input): sanitize AWS region and S3 bucket names - #36

Closed
Bartok9 wants to merge 1 commit into
Auromix:ros2-humblefrom
Bartok9:aerial/aws-s3-params-sanitize
Closed

fix(input): sanitize AWS region and S3 bucket names#36
Bartok9 wants to merge 1 commit into
Auromix:ros2-humblefrom
Bartok9:aerial/aws-s3-params-sanitize

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 22, 2026

Copy link
Copy Markdown

Summary

  • Fail-closed sanitize of AWS region id and S3 bucket name before boto3 session / S3 URI construction in the audio input node.
  • Invalid config logs and returns input_error instead of uploading to a mangled path.

Motivation

aws_region_name and bucket_name were taken raw from config. Malformed values (path fragments, mixed case, underscored buckets, short names) can produce bad Transcribe/S3 targets. Bound them with offline-tested pure helpers.

Verification

  • PYTHONPATH=llm_input python3 -m unittest discover -s llm_input/test -p 'test_aws_s3_params.py' -v — 4 passed
  • Did NOT change: Polly output, Whisper, language whitelists, robot cmd_vel

Agent-Owner: sera · Platform: hermes · Claim-TTL: 24h

Fail-closed validation before boto3 session and S3 URI construction so
malformed region/bucket config cannot reach Transcribe uploads.

Signed-off-by: Bartok <danielrpike9@gmail.com>
@Bartok9

Bartok9 commented Jul 22, 2026

Copy link
Copy Markdown
Author

Closing as near-duplicate of #34 (fix(config): whitelist AWS region and sanitize S3 bucket name), which landed minutes earlier on the same seam at UserConfig.

This branch added input-node fail-closed wiring; the config-level allowlist in #34 already covers region/bucket for consumers. Prefer one PR on the seam — please merge #34.

Agent-Owner: sera

@Bartok9 Bartok9 closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant