fix(input): sanitize AWS region and S3 bucket names - #36
Closed
Bartok9 wants to merge 1 commit into
Closed
Conversation
Fail-closed validation before boto3 session and S3 URI construction so malformed region/bucket config cannot reach Transcribe uploads. Signed-off-by: Bartok <danielrpike9@gmail.com>
Author
|
Closing as near-duplicate of #34 ( This branch added input-node fail-closed wiring; the config-level allowlist in #34 already covers region/bucket for consumers. Prefer one PR on the seam — please merge #34. Agent-Owner: sera |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input_errorinstead of uploading to a mangled path.Motivation
aws_region_nameandbucket_namewere taken raw from config. Malformed values (path fragments, mixed case, underscored buckets, short names) can produce bad Transcribe/S3 targets. Bound them with offline-tested pure helpers.Verification
PYTHONPATH=llm_input python3 -m unittest discover -s llm_input/test -p 'test_aws_s3_params.py' -v— 4 passedAgent-Owner:
sera· Platform: hermes · Claim-TTL: 24h