Skip to content

TC version/locale settings and VersionPayload exchange from PR #47 (tcFunctionalities excluded)#56

Closed
Copilot wants to merge 2 commits into
copilot/carry-forward-tc-functionalitiesfrom
copilot/wip-separate-tcfunctionalities-from-pr-47
Closed

TC version/locale settings and VersionPayload exchange from PR #47 (tcFunctionalities excluded)#56
Copilot wants to merge 2 commits into
copilot/carry-forward-tc-functionalitiesfrom
copilot/wip-separate-tcfunctionalities-from-pr-47

Conversation

Copilot AI commented May 31, 2026

Copy link
Copy Markdown
Contributor

Thanks for the feedback on #55. I've created this new PR, which merges into #55, to address your comment.

Original PR: #55
Triggering review: #55 (review)

Changes

  • Settings: Added get/set_tc_version, get/set_language_code, get/set_country_code with JSON persistence
  • MyTCServer: Accepts configurable TaskControllerVersion (default SecondEditionDraft)
  • app: Creates tcServer with version and locale from settings
  • app: Drives bidirectional VersionPayload exchange via ProcessData PGN callback (on_process_data_pgn_received)

tcFunctionalities and tecuFunctionalities (ControlFunctionFunctionalities announcements) have been removed from this PR and will be addressed in a separate PR.

Copilot AI changed the title [WIP] [WIP] Separate tcFunctionalities from PR #47 as per review feedback TC version/locale settings and VersionPayload exchange from PR #47 (tcFunctionalities excluded) May 31, 2026
Copilot AI requested a review from gunicsba May 31, 2026 20:14
@gunicsba gunicsba closed this May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants