Configurable TC version/locale settings from PR #47

[Copilot]

Extracts the configurable TC version/locale settings from PR #47 into a focused, production-ready change.

Settings (settings.hpp / settings.cpp)

• Added get/set_tc_version() — maps 0–4 to TaskControllerVersion enum; default 3 (SecondEditionDraft) for maximum implement compatibility
• Added get/set_language_code() and get/set_country_code() — defaults "en" / "US"
• All three settings are persisted to / loaded from settings.json

TC Server (task_controller.hpp / task_controller.cpp)

• MyTCServer constructor now accepts an optional TaskControllerVersion parameter (default: SecondEditionDraft, preserving backward compatibility)

Application (app.hpp / app.cpp)

• tcServer is created with the version and locale read from settings instead of hardcoded values

Explicitly excluded from this PR: TC status burst, tcFunctionalities capability announcement, VersionPayload exchange, debug/logging scaffolding, directory archival changes.

Original prompt

Create a new pull request in AgOpenGPS-Official/AOG-TaskController by selectively carrying forward only part of the work from PR #47 ("Add extra logging to understand which ECU-s are on the bus").

Context:

• The existing PR Add extra logging to understand which ECU-s are on the bus #47 was described by the author as an experiment to understand why the Task Controller fails in some cases.
• We want to split the experimental work into focused follow-up PRs.
• This new PR should use the repository's default branch as the base branch.
• A relevant diff reference from PR Add extra logging to understand which ECU-s are on the bus #47 was provided: https://github.com/AgOpenGPS-Official/AOG-TaskController/pull/47/changes#diff-286b37f76a0ca8b723cf42efc1cd6d5e7dd98caee6395366f8ea3dc9f9e9b1dfR78.

Required scope for this PR:

1. Carry over the tcFunctionalities work and everything directly related to it:

   • std::unique_ptr<isobus::ControlFunctionFunctionalities> tcFunctionalities;
   • Ensure any initialization, lifecycle, request/response handling, and integration points required for this functionality are included.
   • Keep the implementation minimal and production-ready; omit unrelated experimentation and debug scaffolding.

2. Carry over the TC version and locale helper API and related logic:

   • std::uint8_t get_tc_version() const;
   • std::string get_language_code() const;
   • std::string get_country_code() const;
   • Include the corresponding setters as well.
   • Retain or implement the underlying state needed for these APIs, including defaults such as DEFAULT_TC_VERSION, DEFAULT_LANGUAGE_CODE, and DEFAULT_COUNTRY_CODE if still appropriate.

3. Implement the VersionPayload exchange toward the implement:

   • Do the request/response dance for the VersionPayload request toward the implement.
   • Integrate this cleanly with the retained TC version / language / country code functionality.
   • Keep behavior aligned with existing project patterns and ISOBUS abstractions already used in the repository.

Explicit exclusions:

• Do not include TC burst changes.
• Do not include extra capabilities work unless required to support tcFunctionalities.
• Do not include extra logging/debug instrumentation.
• Do not include directory archival changes.
• Do not include unrelated cleanup or refactors.

Implementation guidance:

• Review PR Add extra logging to understand which ECU-s are on the bus #47 to identify only the relevant hunks/files.
• Prefer a clean reimplementation/cherry-pick of the minimal required changes over copying experimental code wholesale.
• Ensure the resulting PR is narrowly scoped and clearly described as carrying forward only the functional pieces from PR Add extra logging to understand which ECU-s are on the bus #47.
• If tests exist for this behavior, update/add them as appropriate; otherwise keep validation lightweight and consistent with the repository.

Deliverable:

• Open a new pull request against the repository's default branch in AgOpenGPS-Official/AOG-TaskController with a concise title describing the extracted functionality from PR Add extra logging to understand which ECU-s are on the bus #47.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: ```
constexpr static std::uint8_t DEFAULT_TC_VERSION = 3; // SecondEditionDraft (V3 default for maximum implement compatibility)
static const std::string DEFAULT_LANGUAGE_CODE;
static const std::string DEFAULT_COUNTRY_CODE;

This PR was more like an experiment to understand why the TC fails for some reason.

I'd like you to create a new PR and I'll explain what needs to be carried over.

1 PR about the tcFunctionalities and everything that is related to this:
	std::unique_ptr<isobus::ControlFunctionFunctionalities> tcFunctionalities;

1 PR about the TC_version and other helper functions:
std::uint8_t get_tc_version() const;
std::string get_language_code() const;
std::string get_country_code() const;
(and the setters too)
Do the dance for the VersionPayload request towards the implement.



TC burst, capabilites, extra logging stuff is not needed for now.
Also the directory archival we can skip.




Assistant: I'm waiting for your confirmation on the new pull request task, and once you respond I can continue.

User: @Copilot Accepted Confirmation: Confirm cloud agent session

Assistant: The PR creation didn’t start because the base branch `master` does not exist in `AgOpenGPS-Official/AOG-TaskController`.

If you want, I can retry immediately — either:
- with the repo’s default branch, or
- with the correct branch name if you tell me what it is.

User: use the repos default branch

Assistant: I’ve queued it to use the repository’s default branch, and I’m now waiting for your confirmation so I can start creating the new PR.

This pull request was created from Copilot chat.

[gunicsba]

@copilot I wanted the tcFunctionalities should be in a separate PR. Could we remove all those and keep the rest?
I think the tcFunctionality response should be inside the stack.

[Copilot]

@gunicsba I've opened a new pull request, #56, to work on those changes. Once the pull request is ready, I'll request review from you.

[gunicsba]

@copilot please implement the changes requested in the review / comments

[Copilot]

@copilot please implement the changes requested in the review / comments

Done. All requested changes are addressed in commit $(git rev-parse --short HEAD):

• Removed all tcFunctionalities init/update code and the on_process_data_pgn_received callback (including its registration/deregistration) from app.cpp and app.hpp
• Stripped ISO standard names from all settings.hpp doc comments (ISO 11783-10, ISO 639-1, ISO 3166-1 alpha-2)
• Removed the ISO 11783-12 comment in app.cpp

@copilot I wanted the tcFunctionalities should be in a separate PR. Could we remove all those and keep the rest?
I think the tcFunctionality response should be inside the stack.

All tcFunctionalities code (TC-BAS/TC-GEO/TC-SC announcements, PGN 64654 init, on_process_data_pgn_received VersionPayload callback, and the implementVersionRequested tracking set) has been removed. The TC version/locale settings are kept.

[gunicsba]

Changes look good it should make the Task Controller more flexible this way.