Skip to content

tools: fix wrong voxel offset in MeshToVolume checkNeighbours #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sifakis wants to merge 1 commit into from
+6 −1
Closed

tools: fix wrong voxel offset in MeshToVolume checkNeighbours #2307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openvdb/openvdb/tools/MeshToVolume.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1645,7 +1645,7 @@ checkNeighbours(const Index pos, const typename LeafNodeType::ValueType * data,
// i + 1, j, k
if (mask[0] && Compare::check(data[pos + NodeT::DIM * NodeT::DIM])) return true;
// i+1, j, k-1
if (mask[6] && Compare::check(data[pos + NodeT::DIM * NodeT::DIM])) return true;
if (mask[6] && Compare::check(data[pos + NodeT::DIM * NodeT::DIM - 1])) return true;
// i-1, j, k-1
if (mask[7] && Compare::check(data[pos - NodeT::DIM * NodeT::DIM - 1])) return true;
// i+1, j, k+1
Expand Down
5 changes: 5 additions & 0 deletions pendingchanges/meshtovolumecheckneighboursoffset.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
OpenVDB:
Bug Fixes:
- Fixed an incorrect voxel offset in MeshToVolume.h's checkNeighbours() that caused the
(i+1, j, k-1) edge-adjacent neighbor to be checked at the wrong location, duplicating
the (i+1, j, k) neighbor instead.
Loading