tools: fix wrong voxel offset in MeshToVolume checkNeighbours - #2307
Closed
sifakis wants to merge 1 commit into
Closed
tools: fix wrong voxel offset in MeshToVolume checkNeighbours#2307sifakis wants to merge 1 commit into
sifakis wants to merge 1 commit into
Conversation
The mask[6] branch (i+1, j, k-1) checked data[pos + DIM*DIM], duplicating the mask[0] (i+1, j, k) offset instead of accounting for the k-1 step, unlike the analogous edge-neighbor branches immediately below it. Signed-off-by: Efty Sifakis <esifakis@nvidia.com>
Contributor
Author
|
Superseeded by #2306 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openvdb/openvdb/tools/MeshToVolume.h, thecheckNeighbours()overload that scans a leaf node's rawdataarray has amask[6]branch labeledi+1, j, k-1that checksdata[pos + NodeT::DIM * NodeT::DIM]— the same offset used by themask[0](i+1, j, k) branch two lines above, missing the- 1for thek-1step.mask[7],mask[8],mask[9]) all correctly include the±1z-offset, confirming this is a copy/paste slip rather than intentional.data[pos + NodeT::DIM * NodeT::DIM - 1]so the correct voxel is checked.Test plan
openvdbcore