Skip to content

fix: mention insertion on iOS #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IvanIhnatsiuk merged 1 commit into from
Jul 30, 2026
Merged

fix: mention insertion on iOS #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions ios/styles/MentionStyle.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,18 +308,31 @@ - (void)addMention:(NSString *)indicator
// mention editing should finish
[self removeActiveMentionRange];
} else {
// add a single space after the mention
UITextView *textView = _input->textView;
NSUInteger insertionLocation = textView.selectedRange.location;

[textView.textStorage beginEditing];
[TextInsertionUtils insertText:text
at:_input->textView.selectedRange.location
at:insertionLocation
additionalAttributes:additionalAttributes
input:_input
withSelection:NO];
[TextInsertionUtils insertText:@" "
at:_input->textView.selectedRange.location +
text.length
at:insertionLocation + text.length
additionalAttributes:nil
input:_input
withSelection:YES];
withSelection:NO];
[textView.textStorage endEditing];

// Set selection only after both insertions. This keeps the separator out
// of the mention update and preserves it as plain text.
if (![textView isFirstResponder]) {
[textView reactFocus];
}
textView.selectedRange =
NSMakeRange(insertionLocation + text.length + 1, 0);
[_input setRecentlyChangedRange:NSMakeRange(insertionLocation,
text.length + 1)];
}

// mention editing should finish
Expand Down