fix: mention insertion on iOS - #137
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refines iOS mention insertion in the rich text editor to avoid intermediate editing states and ensure selection/formatting behave correctly when inserting a mention plus a trailing separator.
Changes:
- Batch mention + trailing space insertion using
textStorage beginEditing/endEditingfor a single atomic text storage update. - Move selection update to after both insertions, keeping the separator outside mention formatting.
- Ensure the text view is focused before applying the final selection, and expand
recentlyChangedRangeto include both the mention and trailing space.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refines how mentions are inserted into the text editor, focusing on improving the user experience and ensuring the correct handling of text selection and formatting. The main changes involve batching text insertions, updating selection logic, and ensuring that formatting is preserved.
Mention insertion and selection handling improvements:
beginEditing/endEditingto ensure atomic updates and prevent intermediate state issues.Test Plan
Screenshots / Videos
Screen.Recording.2026-07-30.at.18.58.58.mov
Compatibility