Replaced Zone Upload Estimate with staging buffers#1035
Open
RuffledPlume wants to merge 1 commit into117HD:masterfrom
Open
Replaced Zone Upload Estimate with staging buffers#1035RuffledPlume wants to merge 1 commit into117HD:masterfrom
RuffledPlume wants to merge 1 commit into117HD:masterfrom
Conversation
RuffledPlume
force-pushed
the
StagingZoneUpload
branch
from
15dc780 to
59a7e58
Compare
RuffledPlume
force-pushed
the
StagingZoneUpload
branch
from
59a7e58 to
c19ef32
Compare
* SceneUploader Estimate Functions Removed * `Zone::HasWater` calculated by checking if `uploadZoneWater` writes anything to the vertex buffer * `ZoneUploadJob` now obtains `GPUIntBuffer` from a pool and writes all the zone data before requesting GLBuffers to be created and mapped * StagingBuffers are written to the Mapped Buffers Async GLBuffer::initialize can now take a Buffer for initial content Removed Zone Mapping in favor of simpler `glBufferData` upload since the cost equals out and is significantly less complex Merge Rids, roofStart, roofEnd & levelOffsets into a single object: LevelData Reducing the amount of arrays from 17 to just 2 Build RoofData into a staging array to reduce resulting array size since not all rids will write anything Improve Garbage & Assertion Performance Initialise Zone when `OnCompleted` is called, instead of in a callback Cleanup Reverted Assertions changes
RuffledPlume
force-pushed
the
StagingZoneUpload
branch
from
88b1eff to
93c38a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zone::HasWatercalculated by checking ifuploadZoneWaterwrites anything to the vertex bufferZoneUploadJobnow obtainsGPUIntBufferfrom a pool and writes all the zone data before requesting GLBuffers to be created and mapped