Add new option : type and change data scope#24
Open
Metrakit wants to merge 8 commits intozurb:masterfrom
Open
Conversation
Add the setting "type", and change the scopes "data-pie-id", "data-bar-id", "data-line-id" by "data-chart" with "data-type"
Add type setting and new data scope : "data-chart". "data-chart" replace now "data-pie-id", "data-bar-id", "data-line-id" with "data-type". Example of usage : data-type: 'pie'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this version I have added the option 'type' for changed directly the type in the javascript. Because It's more convenient for have a dynamic content than html semantic.
So in the HTML now we can use data-chart="id" and data-type="pie" for customize the chart.