Skip to content

Remove unnecessary panic #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rkuska wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unnecessary panic #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions middleware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,19 +122,11 @@ type PrometheusPushGateway struct {
}

// NewPrometheus generates a new set of metrics with a certain subsystem name
func NewPrometheus(subsystem string, customMetricsList ...[]*Metric) *Prometheus {
func NewPrometheus(subsystem string, customMetricsList ...*Metric) *Prometheus {

var metricsList []*Metric

if len(customMetricsList) > 1 {
panic("Too many args. NewPrometheus( string, <optional []*Metric> ).")
} else if len(customMetricsList) == 1 {
metricsList = customMetricsList[0]
}

for _, metric := range standardMetrics {
metricsList = append(metricsList, metric)
}
metricsList := make([]*Metric, 0, len(customMetricsList)+len(standardMetrics))
metricsList = append(metricsList, customMetricsList...)
metricsList = append(metricsList, standardMetrics...)

p := &Prometheus{
MetricsList: metricsList,
Expand Down