Skip to content

Add GUI artifact build to the CI#535

Merged
MichaelTimbert merged 5 commits into
zonemaster:developfrom
MichaelTimbert:artifact
Jun 17, 2026
Merged

Add GUI artifact build to the CI#535
MichaelTimbert merged 5 commits into
zonemaster:developfrom
MichaelTimbert:artifact

Conversation

@MichaelTimbert

@MichaelTimbert MichaelTimbert commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Purpose

This PR adds artifact creation to CI. This artifact can be useful for release testing and PR review.
The artifact is created only if all tests pass.

Context

Follow-up to zonemaster/zonemaster-backend#1229

How to test this PR

You should be able to download the artifact from the action tab and install it by following the Zonemaster documentation.
https://doc.zonemaster.net/latest/installation/zonemaster-gui.html

@matsduf matsduf added V-Patch Versioning: The change gives an update of patch in version. RC-None Release category: Not to be included in Changes file. labels Feb 25, 2026
@matsduf matsduf added this to the v2026.1 milestone Feb 25, 2026
@matsduf

matsduf commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

I assume that the zip file has been created by this PR since all tests pass, but I cannot see where to find it.

@marc-vanderwal

Copy link
Copy Markdown
Contributor

The artifact that was generated for this build is here: https://github.com/zonemaster/zonemaster-gui/actions/runs/22368424280.

At first glance it looks fine. It’s a ZIP archive inside another ZIP archive, which is weird, but this is a limitation inherent to the GitHub action. Its documentation states:

When an Artifact is uploaded, all the files are assembled into an immutable Zip archive. There is currently no way to download artifacts in a format other than a Zip or to download individual artifact contents.

@matsduf

matsduf commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

The artifact that was generated for this build is here: https://github.com/zonemaster/zonemaster-gui/actions/runs/22368424280.

Now I can see it, but it is not very easy to find unless you know exactly where to look for it.

@matsduf

matsduf commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

I will test the zip file.

@matsduf matsduf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but we need some documentation how to find the zip file.

I think that we should always use the zip file created by CI for release testing and release. Preferably also for PR testing.

This could be taken a step further. If you want to build your customized GUI, create a fork and create a PR against develop branch. That means that you do not have set the GUI build environment up.

@matsduf matsduf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some documentation where to find the zip file. Could you add a small document how to find the zip file? Maybe it could be in the main README.md in this repository?

Comment thread README.md Outdated
matsduf
matsduf previously approved these changes Jun 11, 2026
@matsduf

matsduf commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@MichaelTimbert, can you rebase this on updated develop (updated CI settings)?

@matsduf matsduf changed the title Add artifact build to the CI Add GUI artifact build to the CI Jun 16, 2026
@matsduf

matsduf commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Should this be moved back to v2026.1?

@matsduf

matsduf commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Should this be moved back to v2026.1?

If not, it should NOT be merged to develop before release.

@marc-vanderwal

Copy link
Copy Markdown
Contributor

I think it’s harmless to move it back to 2026.1.

@matsduf

matsduf commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I think it’s harmless to move it back to 2026.1.

I agree.

@MichaelTimbert MichaelTimbert merged commit 6f4e6c6 into zonemaster:develop Jun 17, 2026
2 checks passed
@matsduf matsduf modified the milestones: v2026.1.1, v2026.1 Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RC-None Release category: Not to be included in Changes file. V-Patch Versioning: The change gives an update of patch in version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants