Add GUI artifact build to the CI#535
Conversation
|
I assume that the zip file has been created by this PR since all tests pass, but I cannot see where to find it. |
|
The artifact that was generated for this build is here: https://github.com/zonemaster/zonemaster-gui/actions/runs/22368424280. At first glance it looks fine. It’s a ZIP archive inside another ZIP archive, which is weird, but this is a limitation inherent to the GitHub action. Its documentation states:
|
Now I can see it, but it is not very easy to find unless you know exactly where to look for it. |
|
I will test the zip file. |
There was a problem hiding this comment.
I think this is fine, but we need some documentation how to find the zip file.
I think that we should always use the zip file created by CI for release testing and release. Preferably also for PR testing.
This could be taken a step further. If you want to build your customized GUI, create a fork and create a PR against develop branch. That means that you do not have set the GUI build environment up.
matsduf
left a comment
There was a problem hiding this comment.
We need some documentation where to find the zip file. Could you add a small document how to find the zip file? Maybe it could be in the main README.md in this repository?
|
@MichaelTimbert, can you rebase this on updated develop (updated CI settings)? |
Co-authored-by: Mats Dufberg <mats.dufberg@iis.se>
|
Should this be moved back to v2026.1? |
If not, it should NOT be merged to develop before release. |
|
I think it’s harmless to move it back to 2026.1. |
I agree. |
Purpose
This PR adds artifact creation to CI. This artifact can be useful for release testing and PR review.
The artifact is created only if all tests pass.
Context
Follow-up to zonemaster/zonemaster-backend#1229
How to test this PR
You should be able to download the artifact from the action tab and install it by following the Zonemaster documentation.
https://doc.zonemaster.net/latest/installation/zonemaster-gui.html