Docker build: fix for Net-IDN-Encode#459
Conversation
|
@MichaelTimbert, please set label and milestone on this PR. Should we change for other installations of CLI, or just Docker? |
mattias-p
left a comment
There was a problem hiding this comment.
I have one formatting nit. Otherwise this LGTM.
|
Something must have gone wrong applying the patch. Now there are lots of duplicated lines. Or maybe I did something wrong creating the suggestion. |
| perl-test-differences \ | ||
| perl-test-nowarnings \ | ||
| perl-try-tiny \ | ||
| ``` |
There was a problem hiding this comment.
Remove the tripple backtick on line 23.
|
After removing the tripple backticks in Dockerfile I can build the CLI Docker image, but I get the following strange error: |
Can you try and build from Engine with latest develop? There indeed was a missing import of this method, which was fixed by https://github.com/zonemaster/zonemaster-engine/pull/1530/changes#diff-9779582974eb66a438c0c1a289b489dd916130b93ca91f269b1cd42ece585e9dR18 (merged an hour ago) |
I created a new image and that does not give the error. |
Co-authored-by: Mattias Päivärinta <mattias@paivarinta.se>
1dc2ae3 to
5c89b77
Compare
Purpose
Fix Docker image build failure caused by
Net::IDN::Encodeno longercompiling with current toolchain versions.
Context
The upstream
Net::IDN::Encodemodule has not been updated sinceJanuary 2022 and fails to build from source in the current Alpine-based
Docker image. A community-provided fix exists in
cfaerber/Net-IDN-Encode#11,
and a trial release incorporating the fix is available on CPAN:
Net-IDN-Encode-2.501-TRIAL.
I ran a quick AI check on the proposed fix and it doesnt find suspicious or malicious code.
Changes
build-base,perl-test-nowarnings,perl-dev)required to compile
Net::IDN::Encodefrom source.Net-IDN-Encode-2.501-TRIALfrom CPAN before the remainingcpanmdependencies, so that the patched version satisfies anydownstream requirements.
How to test this PR
The docker image build should complete without errors. Optionally verify the module
loads correctly: