Display an error when trying to add an user with a non-localhost IP#889
Merged
3 commits merged intoOct 13, 2021
Merged
Conversation
added 2 commits
October 12, 2021 15:33
The "add_api_user" method should be called from a local IP.
matsduf
requested changes
Oct 12, 2021
matsduf
left a comment
Contributor
There was a problem hiding this comment.
This is fine and works fine, but one comment on wording.
matsduf
approved these changes
Oct 13, 2021
Contributor
Testing v2021.2LGTM. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When trying to call
add_api_userfrom a non-localhost IP, no error message is sent to the client, nor logged. This emits an error message using the custom error handling from #847.Context
Emit an error when calling
add_api_userfrom a remote IP.Changes
Update the
add_api_usermethod and update the API documentation with an output example.How to test this PR
Calling the
add_api_userfrom a remote IP should send back an error message. For instancecurl -s "Content-Type: application/json" --data '{"method":"add_api_user","params:{"username":"toto","api_key":"toto"},"id":1,"jsonrpc":"2.0"}' http://10.0.0.1:5000/ | jqshould return something like