Skip to content

feat(tui): generate TuiCore via fluessig single_threaded handle#345

Draft
zmaril wants to merge 1 commit into
napi-fluessig/select-list-corefrom
napi-fluessig/tui-core
Draft

feat(tui): generate TuiCore via fluessig single_threaded handle#345
zmaril wants to merge 1 commit into
napi-fluessig/select-list-corefrom
napi-fluessig/tui-core

Conversation

@zmaril

@zmaril zmaril commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Swap the hand-written TuiCore napi class (src/tui.rs, the native half of pi's differential renderer) for a fluessig-generated one — the largest UI core yet (ctor + 12 sync ops), extending the #80 single_threaded (thread-confined !Send) handle path proven by InputCore (#341) and SelectListCore (#344).

What changed

  • Author the ctor + twelve sync ops in schema/api.json, marking the interface single_threaded: true. fluessig lowers it to a THREAD-CONFINED handle pub struct TuiCore { core: RefCell<TuiCoreImpl> } — no Arc, no Send/Sync — with the TuiCoreCore trait shedding Send + Sync (Sized + 'static), &mut self ops reached through borrow_mut().
  • TuiCoreImpl (core_impl.rs) owns pi's !Send Tui<LoggingTerminal>, whose differential renderer holds Rc<RefCell<dyn Component>> children and non-Send closures. Every op is sync — no streaming/async — so nothing is carved @manual; the tick fallibility (Result<()>) rides the trait's anyhow::Result seam.
  • regen src/generated.rs (fluessig e056bb9); delete src/tui.rs and its mod tui; in lib.rs; keep pub mod generated;.

Gates

  • Byte-transparent: the generated TuiCore .d.ts block, .js export, and nativeBinding entry are byte-identical to the pre-swap build.
  • cargo build/fmt/clippy -D warnings clean; codespell 0; straitjacket v0.2.3 0 errors.
  • Oracle: pi's own test/tui-render.test.ts (23/23) and test/tui-shrink.test.ts (1/1) pass against the locally-built addon.

Stacked on napi-fluessig/select-list-core (#344, SelectListCore) → napi-fluessig/single-threaded-tui (#341, InputCore).

🤖 Generated with Claude Code

https://claude.ai/code/session_017xL2W7dkhPsTSRuXQNCDeY


Generated by Claude Code

Swap the hand-written `TuiCore` napi class (src/tui.rs, the native half of
pi's differential renderer, packages/tui/src/tui.ts) for a fluessig-generated
one — the largest UI core yet (ctor + 12 sync ops), extending the #80
single_threaded (thread-confined `!Send`) handle path proven by InputCore
(#341) and SelectListCore:

- Author the ctor + twelve sync ops in schema/api.json, marking the interface
  `single_threaded: true`. fluessig lowers it to a THREAD-CONFINED handle:
  `pub struct TuiCore { core: RefCell<TuiCoreImpl> }` — no `Arc`, no
  `Send`/`Sync` — and the `TuiCoreCore` trait sheds its `Send + Sync`
  supertraits (`Sized + 'static`) with `&mut self` ops reached through
  `borrow_mut()`.
- This is what lets a `!Send` core compile: `TuiCoreImpl` (core_impl.rs) owns
  pi's `Tui<LoggingTerminal>`, whose differential renderer holds
  `Rc<RefCell<dyn Component>>` children and non-`Send` closures. Every op is
  sync — no streaming/async — so nothing is carved `@manual`. The `tick`
  fallibility (`Result<()>`) rides the trait's `anyhow::Result` seam; the
  `to_usize` dimension clamp moves with it.
- regen src/generated.rs (fluessig e056bb9); delete src/tui.rs and its
  `mod tui;` in lib.rs; keep `pub mod generated;`.

Self-mutability is invisible to the TS type, so the RefCell-vs-`&mut self`
handle is byte-transparent: the generated `TuiCore` class `.d.ts` block, the
`.js` export, and the nativeBinding entry are all byte-identical to the
pre-swap build. pi's own test/tui-render.test.ts (23/23) and
test/tui-shrink.test.ts (1/1) oracles pass against the locally-built addon.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017xL2W7dkhPsTSRuXQNCDeY
@github-actions

Copy link
Copy Markdown

Conformance smoke: agent + ai + tui

  • pi_sha: 3da591ab74ab9ab407e72ed882600b2c851fae21
  • manifest_native_modules: 45

Headline is rust-backed: passing cases in files whose module-under-test is a native (Rust addon) module. Raw all-pass is shown secondary — it is inflated by unflipped TypeScript that passes without touching any Rust.

Package rust-backed Native modules raw pass (secondary) Failing Skipped
agent 55/180 (30.6%) 5 180/180 0 0
ai 74/1296 (5.7%) 8 553/1296 3 740
tui 375/678 (55.3%) 14 678/678 0 0
smoke total 504/2154 (23.4%) 27 1411/2154 3 740

agent: 55/180 (30.6%) · ai: 74/1296 (5.7%) · tui: 375/678 (55.3%)

rust-backed = passing / total tests run, per the manifest's per-native-row tests lists. The Native modules column counts modules served by the Rust addon. This is the agent+ai+tui smoke subset; the full baseline lives in committed conformance.json.

Attribution

A pi test file is rust-backed iff the module it primarily exercises — its module-under-test — is status=native in conformance/manifest.json. A package's rust-backed count is the passing cases in its rust-backed files. Transitive or infrastructure use does not count (e.g. ~30 ai files construct the native faux provider but test other things — only faux-provider.test.ts, whose subject is faux, counts). A file that substantially tests both a native and an original module is excluded rather than counted, so the number under-reports rather than over-claims.

Per-file decisions (from each native manifest row's tests list):

Native module Test file Decision
ai/api/anthropic-messages.ts test/anthropic-sse-parsing.test.ts counted
ai/providers/faux.ts test/faux-provider.test.ts counted
coding-agent/utils/ansi.ts test/ansi-utils.test.ts counted
coding-agent/utils/changelog.ts test/changelog.test.ts counted
coding-agent/utils/git.ts test/git-ssh-url.test.ts counted
coding-agent/core/tools/path-utils.ts test/path-utils.test.ts counted
tui/keys.ts test/keys.test.ts counted
tui/utils.ts test/truncate-to-width.test.ts, test/regression-regional-indicator-width.test.ts counted
coding-agent/utils/mime.ts test/image-process.test.ts mixed — excluded (2 of 3 cases test processImage/original)
coding-agent/utils/version-check.ts test/version-check.test.ts mixed — excluded (fetch cases mock the original; not separable per-file)
coding-agent/core/export-html/ansi-to-html.ts test/export-html-whitespace.test.ts mixed — excluded (asset-grep + tool-renderer/original dominate)
coding-agent/core/tools/truncate.ts no dedicated test (exercised via tools.test.ts, subject is the read/edit factory/original)
coding-agent/core/tools/edit-diff.ts no dedicated test (edit-tool tests' subject is the edit tool/original)

CLI conformance (black-box, against the pidgin binary)

  • CLI conformance: 15/15 pass against target/release/pidgin (pass delta ±0, fail delta ±0).
File Passing Failing Skipped
packages/coding-agent/test/session-file-invalid.test.ts 1 0 0
packages/coding-agent/test/session-id-readonly.test.ts 7 0 0
packages/coding-agent/test/startup-session-name.test.ts 2 0 0
packages/coding-agent/test/stdout-cleanliness.test.ts 5 0 0

The four repointed coding-agent CLI test files spawn the compiled pidgin binary via $PIDGIN_BIN instead of pi's own cli.ts. This is a separate signal from the module smoke table and is never folded into the per-package Native count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants