refactor: extract core/provers/ffi architecture with clean dependency…#716
Draft
vivianjeng wants to merge 5 commits into
Draft
refactor: extract core/provers/ffi architecture with clean dependency…#716vivianjeng wants to merge 5 commits into
vivianjeng wants to merge 5 commits into
Conversation
… boundaries Introduces the new monorepo architecture per CLAUDE.md: - core/: Prover trait, MoproError, ProofBytes — zero FFI deps - provers/circom-adapter, halo2-adapter, noir-adapter: thin Prover impls with optional uniffi/wasm/flutter feature gates on output types - ffi/common: Arch/Mode/PlatformBuilder traits + shared build utilities - ffi/uniffi, ffi/wasm, ffi/flutter, ffi/react-native: build-pipeline backends; each defines its own Platform struct (orphan rule), zero deps on core or provers - scripts/check-boundaries.sh: CI-ready boundary invariant check - tests/build.rs: replaces src/bin/*.rs; backends triggered via env vars (IOS_ARCHS, ANDROID_ARCHS, WEB_ARCHS, FLUTTER_ARCHS, REACT_NATIVE_ARCHS) - .github/workflows/new-arch.yml: check/test/boundary/binding_ios/binding_wasm jobs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying mopro with
|
| Latest commit: |
2016c2a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://43363476.mopro.pages.dev |
| Branch Preview URL: | https://refactor-with-ai.mopro.pages.dev |
…exist
patch_package_version now reads Cargo.lock to detect whether a package
has multiple versions. When it does, it uses the `name@x.y.z` spec to
target the correct major version instead of failing with an ambiguity error.
Also replace Command::new("cargo") with env CARGO in ios/android/wasm
backends so nested cargo calls from build.rs use the correct binary.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…fi from host build tests/ is now a pure build-pipeline driver (no lib code, no mopro-ffi dep). test-app/ holds the actual library that gets compiled for iOS/Android/Wasm. build_from_env_at(project_dir) added to mopro-build-common; each backend exposes build_at(project_dir) so tests/build.rs can point at test-app/. This avoids compiling mopro-ffi and linking cdylib/staticlib for the host when running `cargo build -p tests`, significantly reducing CI cold-build time. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Without this, build.rs inherits the build script's working directory (tests/) instead of project_dir (test-app/), causing the nested build to compile the wrong crate. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… boundaries
Introduces the new monorepo architecture per CLAUDE.md: