feat: Ironwood support

.cargo/config.toml

@@ -1,84 +1,7 @@
 # Zebra cargo configuration
 
-# Flags that apply to all Zebra crates and configurations
-[target.'cfg(all())']
-rustflags = [
-    # Zebra standard lints for Rust 1.65+
-
-    # High-risk code
-    "-Dunsafe_code",
-    "-Dnon_ascii_idents",
-
-    # Potential bugs
-    #
-    # If we deny these lints, we could be excluded from Crater builds:
-    # https://www.reddit.com/r/rust/comments/f5xpib/psa_denywarnings_is_actively_harmful/
-
-    # Compatibility
-    "-Wrust_2021_compatibility",
-    "-Wnonstandard_style",
-    "-Wfuture_incompatible",
-
-    # Async code
-    "-Wclippy::await_holding_lock",
-    "-Wclippy::await_holding_refcell_ref",
-
-    # Pointers
-    "-Wclippy::cast_ptr_alignment",
-    "-Wclippy::fn_to_numeric_cast_any",
-
-    # Integers
-    "-Wclippy::checked_conversions",
-    "-Wclippy::implicit_saturating_sub",
-    "-Wclippy::invalid_upcast_comparisons",
-    "-Wclippy::range_minus_one",
-    "-Wclippy::range_plus_one",
-    "-Wclippy::unnecessary_cast",
-
-    # Incomplete code
-    "-Wclippy::dbg_macro",
-    "-Wclippy::todo",
-
-    # Manual debugging output.
-    # Use tracing::trace!() or tracing::debug!() instead.
-    "-Wclippy::print_stdout",
-    "-Wclippy::print_stderr",
-    "-Wclippy::dbg_macro",
-
-    # Code styles we want to accept
-    "-Aclippy::try_err",
-
-    # Panics
-    "-Wclippy::fallible_impl_from",
-    "-Wclippy::unwrap_in_result",
-
-    # Documentation
-    "-Wmissing_docs",
-
-    # TODOs:
-    # Fix this lint eventually.
-    "-Aclippy::result_large_err",
-
-    # `cargo fix` might help do these fixes,
-    # or add a config.toml to sub-directories which should allow these lints,
-    # or try allowing the lint in the specific module (lib.rs doesn't seem to work in some cases)
-    #
-    # lint configs that don't work:
-    # - allowing these lints in lib.rs (command-line warn overrides allow in lib.rs?)
-    # - adding a [target.'cfg(not(test))'] rustflags config (it runs on test code anyway)
-
-    # fix code that triggers these lints,
-    # or disable the lint for that code (or for all test code)
-    #
-    #"-Wclippy::cast_lossless", # 30 non-test warnings, a few test warnings
-    #"-Wclippy::cast_possible_truncation", # 40 non-test warnings, 20 test warnings
-    #"-Wclippy::cast_possible_wrap", # 13 test warnings (fixed outside tests)
-    #"-Wclippy::cast_precision_loss", # 25 non-test warnings, 10 test warnings
-    #"-Wclippy::cast_sign_loss", # 6 non-test warnings, 15 test warnings
-
-    # fix hidden lifetime parameters
-    #"-Wrust_2018_idioms",
-]
+[alias]
+xtask = "run --package xtask --"
 
 [build]
 rustdocflags = [
@@ -91,3 +14,7 @@ rustdocflags = [
 
 [env]
 RUST_BACKTRACE="1"
+
+[profile.profiling]
+inherits = "release"
+debug = true

.codespellrc

@@ -1,4 +1,4 @@
 [codespell]
-ignore-words-list = crate,Sur,inout,Groth,groth,re-use,abl,
+ignore-words-list = crate,Sur,inout,Groth,groth,re-use,abl,zcash,zcashd,zebrad,zebra,utxo,utxos,nullifier,nullifiers,sapling,orchard,sprout,backpressure,proptest,thiserror,rocksdb,libsecp,fullnode,peerset,threadsafe,unrepresentable,getblocktemplate,syncer,Actix,Akka,mermaid,println,eprintln,usize,nocapture,Parallelizable,invis,UTXO,Zcash,Zaino,Zallet,librustzcash,Mainnet,Testnet,mainnet,testnet,idents,reentrancy,serializable,deserializable,deserialization,zkSNARK,zkSNARKs,lightwalletd,statics,ser,endianity,aranges,daa
 exclude-file = book/mermaid.min.js
-skip = ./zebra-rpc/qa/rpc-tests,./supply-chain
+skip = ./zebra-rpc/qa/rpc-tests,./supply-chain,./target

.config/nextest.toml

@@ -30,13 +30,25 @@ filter = "not test(=trusted_chain_sync_handles_forks_correctly) and not test(=de
 # TODO: We need a better test architecture to run all non-stateful
 [profile.all-tests]
 failure-output = "immediate"
-default-filter = "not test(check_no_git_dependencies) and not test(=fully_synced_rpc_z_getsubtreesbyindex_snapshot_test) and not test(=lwd_rpc_test) and not test(=lwd_rpc_send_tx) and not test(=lwd_grpc_wallet) and not test(=lwd_integration) and not test(=lwd_sync_full) and not test(=lwd_sync_update) and not test(=lightwalletd_test_suite) and not test(=rpc_get_block_template) and not test(=rpc_submit_block) and not test(=get_peer_info) and not test(~generate_checkpoints_) and not test(=sync_update_mainnet) and not test(=activate_mempool_mainnet)"
+default-filter = "not test(check_no_git_dependencies) and not test(=fully_synced_rpc_z_getsubtreesbyindex_snapshot_test) and not test(=lwd_rpc_test) and not test(=lwd_rpc_send_tx) and not test(=lwd_grpc_wallet) and not test(=lwd_integration) and not test(=lwd_sync_full) and not test(=lwd_sync_update) and not test(=lightwalletd_test_suite) and not test(=rpc_get_block_template) and not test(=rpc_submit_block) and not test(=get_peer_info) and not test(~generate_checkpoints_) and not test(=sync_update_mainnet) and not test(=activate_mempool_mainnet) and not test(=sync_large_checkpoints_mempool_mainnet) and not test(cluster_forms_native_two_node_mesh) and not test(=pruned_storage_mode_prunes_during_regtest_sync)"
+
+# --- Full Tests profile ---
+# Broader coverage for `ironwood-main`, scheduled, manual, and merge-queue runs.
+# This preserves the previous `all-tests` selection while the PR lane stays fast.
+[profile.full-tests]
+failure-output = "immediate"
+default-filter = "not test(check_no_git_dependencies) and not test(=fully_synced_rpc_z_getsubtreesbyindex_snapshot_test) and not test(=lwd_rpc_test) and not test(=lwd_rpc_send_tx) and not test(=lwd_grpc_wallet) and not test(=lwd_integration) and not test(=lwd_sync_full) and not test(=lwd_sync_update) and not test(=lightwalletd_test_suite) and not test(=rpc_get_block_template) and not test(=rpc_submit_block) and not test(=get_peer_info) and not test(~generate_checkpoints_) and not test(=sync_update_mainnet) and not test(=activate_mempool_mainnet) and not test(=sync_large_checkpoints_mempool_mainnet) and not test(cluster_forms_native_two_node_mesh)"
 
 # --- Individual Test Profiles ---
 
 [profile.check-no-git-dependencies]
 default-filter = 'test(check_no_git_dependencies)'
 
+[profile.zakura-integration]
+retries = 2
+slow-timeout = { period = "15m", terminate-after = 1 }
+default-filter = 'package(zebra-network) and test(~zakura)'
+
 [profile.sync-large-checkpoints-empty]
 slow-timeout = { period = "60m", terminate-after = 2 }
 default-filter = 'package(zebrad) and test(=sync_large_checkpoints_empty)'
@@ -74,6 +86,22 @@ default-filter = 'package(zebrad) and test(=sync_past_mandatory_checkpoint_mainn
 slow-timeout = { period = "60m", terminate-after = 2 }
 default-filter = 'package(zebrad) and test(=sync_past_mandatory_checkpoint_testnet)'
 
+[profile.sync-range-pre-nu62]
+# A healthy 5k-window sync is ~3-5 min. Terminate a stalled (broken) sync at ~20 min so a
+# consensus regression fails fast and cleanly (a real test timeout) instead of waiting out the
+# job-level timeout. Generous margin over the healthy duration to avoid flakes on a slow droplet.
+slow-timeout = { period = "5m", terminate-after = 4 }
+success-output = "immediate"
+default-filter = 'package(zebrad) and test(=sync_range_pre_nu62)'
+
+[profile.sync-range-post-nu62]
+# A healthy 5k-window sync is ~3-5 min. Terminate a stalled (broken) sync at ~20 min so a
+# consensus regression fails fast and cleanly (a real test timeout) instead of waiting out the
+# job-level timeout. Generous margin over the healthy duration to avoid flakes on a slow droplet.
+slow-timeout = { period = "5m", terminate-after = 4 }
+success-output = "immediate"
+default-filter = 'package(zebrad) and test(=sync_range_post_nu62)'
+
 [profile.generate-checkpoints-mainnet]
 slow-timeout = { period = "90m", terminate-after = 1 }
 success-output = "immediate"

.cursor/skills/zakura-trace-plots/SKILL.md

@@ -0,0 +1,67 @@
+---
+name: zakura-trace-plots
+description: Generate metrics-aware plots and summaries from Zebra Zakura perf trace directories. Use when the user asks to plot or analyze Zakura traces, block_sync.jsonl, commit_state.jsonl, feedrun CSVs, applying/reorder/stalls, HoL stalls, throughput, or commit metrics from a trace_dir.
+---
+
+# Zakura Trace Plots
+
+## Quick Start
+
+When the user gives a Zakura `trace_dir`, generate plots with:
+
+```bash
+python3 .cursor/skills/zakura-trace-plots/scripts/plot_zakura_traces.py TRACE_DIR --out-dir perf-artifacts
+```
+
+If the matching feed-run CSV is not auto-detected, pass it explicitly:
+
+```bash
+python3 .cursor/skills/zakura-trace-plots/scripts/plot_zakura_traces.py TRACE_DIR --csv /root/wal-bench/feedrun-r1.csv --out-dir perf-artifacts
+```
+
+## What To Plot
+
+Default outputs:
+
+- `*-time-apply-reorder-stalls-bps.svg`
+- `*-height-apply-reorder-stalls-bps.svg`
+- `*-summary.txt`
+
+Use the time plot for stall diagnosis. Height plots collapse zero-progress stalls onto one x-position.
+
+## Metrics Awareness
+
+Use `block_sync.jsonl` as the source of truth for:
+
+- `applying`
+- `reorder`
+- `unsubmitted_applying_count`
+- `submitted_applies`
+- byte counters like `applying_buffered_bytes` and `retained_pipeline_wire_bytes`
+- floor-gap states such as `outstanding`, `queued`, and `in_flight_without_outstanding`
+
+Use the CSV only for sampled node metrics:
+
+- `blk_s`, recomputed from finalized height deltas while skipping startup `0 -> snapshot` jumps
+- commit phase counters like `sur`, `ar`, `bp`, `bc`
+- `cpu_cores`, peers, and other sampler-only columns
+
+Do not trust the CSV `reorder` column unless verified against `block_sync.jsonl`; in prior runs it was effectively zero while trace reorder was thousands.
+
+## Interpreting Output
+
+HoL/body-floor stall signature:
+
+- `applying` collapses near zero
+- `reorder` grows
+- `blk_s` drops near zero
+- trace floor-gap state is usually `outstanding`
+
+Commit/memory-pressure signature:
+
+- `applying` and submitted applies stay high
+- `reorder` stays low
+- `spent_utxo_reads` or other commit phases spike
+- host memory pressure or retained pipeline bytes rise
+
+When summarizing, report the generated file paths and the strongest signature, not every metric.