Rename makers test set package -> packages#1355
Open
zancas wants to merge 2 commits into
Open
Conversation
The front-door test set is named for the `packages/` directory it runs, so the plural is the faithful name. Hard-cut: `makers test package` now errors with `unknown set` rather than aliasing. Updates every reference site: Makefile.toml (default, case matcher, dispatch, descriptions, comment block), help.sh, docs/testing.md, README.md, and the live-tests/CONTEXT.md glossary term (now records the retired singular under _Avoid_). ADR-0004 gets a one-line supersession footer; its historical text is preserved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1354 merge that first.
What
Renames the
makers testfront-door test set frompackage(singular) topackages(plural). The set is named for thepackages/directory whose crates it runs, so the plural is the faithful name.Hard-cut, no alias:
makers test packagenow errors withunknown set(thecasematcher already fails loudly on unknown sets), rather than silently aliasing. No CI invokes the set name, so nothing automated breaks.Changes
Makefile.toml—testtask default (set="packages"),casematcher, dispatch arm, both task descriptions, usage text, and the comment/groupings block.tools/scripts/help.sh— theCommon usageline and thetest [SET]menu.docs/testing.md,README.md— front-door prose.live-tests/CONTEXT.md— glossary termpackage (test set)→packages (test set); the retired singular is now recorded under_Avoid_with a note that it errors.docs/adr/0004— one-line supersession footer; historical text preserved.Out of scope
The
PACKAGE/PACKAGE_DESCenv vars inlive-clientless/live-e2ehold partition names, not the test-set name — a pre-existing naming collision left untouched here.🤖 Generated with Claude Code