Abstract devtool coupling behind a general client interface

[Timi16]

• Introduce TestWallet trait, WalletPoolBalances, and TestClients generic struct so wallet-test code depends on a
  backend-agnostic interface rather than devtool specifics (Abstract devtool coupling behind a general client interface #1264).

  • Replace hand-rolled txid_internal_bytes with TxId-based txid_from_devtool — uses the proven ecosystem type from
    zcash_primitives instead of raw byte manipulation.
  • Return Zatoshis from balance accessors instead of raw u64, enforcing type-safe amount handling throughout test assertions.

  Addresses nachog00's review feedback on PR excise zingolib, replace with devtool #1259 and pacu's review comments.

  Refs Abstract devtool coupling behind a general client interface #1264, Follow-Up to MVP devtool migration, necessary for full coverage and coherent upstream tracking #1262

  Test plan

  • cargo check --tests passes in integration-tests/wallet-tests/
  • cargo clippy --tests passes with no new warnings
  • Existing devtool integration tests (devtool.rs, devtool_zcashd.rs, test_vectors.rs) compile and run unchanged against a local
    regtest node
  • Verify that TestWallet trait is the only interface test bodies depend on (no direct DevtoolClients method calls remain)

[zancas]

If you can produce a variant of this that does not add new dependencies that would be more interesting.

[Timi16]

If you can produce a variant of this that does not add new dependencies that would be more interesting.

Okat alright would look into it thank you

[zancas]

Moving to draft until it removes new dependencies.

[Timi16]

Moving to draft until it removes new dependencies.

Made changes and ready to review

[zancas]

Why isn't this PR'd against https://github.com/zingolabs/infrastructure ?

[Timi16]

The changes in this PR live entirely in integration-tests/wallet-tests/. It adds TestWallet, WalletPoolBalances, TestClients<W>, and the TestWallet impl for the ZcashDevtool adapter — all inside Zaino’s own test harness. Nothing in zcash_local_net or the infrastructure was modified.

The abstraction wraps zcash_local_net::client::Client so that Zaino’s test bodies depend on a backend-agnostic trait (TestWallet) rather than directly calling ZcashDevtool methods. This decoupling is on the Zaino side: it lets us swap or add wallet backends (e.g. a future zingolib or mock backend) without touching the infrastructure.

The TestWallet impl for ZcashDevtool lives here because it adapts an external type (ZcashDevtool) to a Zaino-local trait (TestWallet), which is exactly where Rust’s orphan rules require it to live.

[Timi16]

Let me get back to work

[zancas]

OK marking draft for now.

[Timi16]

OK marking draft for now.

Okay

[Timi16]

OK marking draft for now.

Why did you make this a draft please would love to know