Bound GetAddressUtxos result materialization#1173
Draft
Zk-nd3r wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #974 by threading the
start_heightandmax_entriesrequest bounds into the internalGetAddressUtxospath instead of materializing the full converted result first.What changed
AddressUtxosRequestcarrying addresses,start_height, and optionalmax_entries.ChainIndex::get_address_utxos_bounded(...)while preserving the existing unboundedget_address_utxos(...)behavior.Vec<GetAddressUtxos>stops at the requested limit.getaddressutxosRPC has no height/limit parameters.Nonebounds,max_entries=Some(1), andstart_heightfiltering.Validation
Ran against current
zingolabs:dev(c4d8f381):rustfmt --edition 2021 --checkon the 8 changed filesgit diff --cached --checkcargo check -p zaino-state -p zaino-fetchcargo test -p zaino-state get_address_utxos -- --nocapture1 passed; 0 failed; 139 filtered out