Show places on the Plaza page, and refresh the shots - #19
Merged
Conversation
The Plaza page describes places in prose and showed nothing. Same four pictures as the app's own README, now including the one that shipped in v0.12.0 and had no image anywhere. The shots themselves were from around v0.2.x, before the rails, places and the Info card, and from before the font baseline fix, so the published images carried a text misalignment the app has not had since v0.12.0. The panel grid gains a four-up variant rather than changing `.zn-shots` itself. That class is shared with the signer page, which has three panels and would have been stretched to four columns with one empty. Plaza's row goes two-by-two and opens out to four above 1100px, where there is room to read them.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Plaza page describes places in prose and showed nothing. Same four pictures as the app's own README, now including the one that shipped in v0.12.0 and had no image anywhere.
The shots themselves were from around v0.2.x, before the rails, places and the Info card, and from before the font baseline fix, so the published images carried a text misalignment the app has not had since v0.12.0.
The panel grid gains a four-up variant rather than changing
.zn-shotsitself. That class is shared with the signer page, which has three panels and would have been stretched to four columns with one empty. Plaza's row goes two-by-two and opens out to four above 1100px, where there is room to read them.