refactor: decouple model capabilities from static ModelInfo registry#144
Merged
MaleicAcid merged 1 commit intoMay 22, 2026
Merged
Conversation
- Remove max_tokens/context_window from ModelInfo (registry is now pricing-only) - Add these fields as optional overrides on ModelConfig - Rewrite _compute_max_tokens to return int|None: None means don't send max_tokens to API (server decides); when set, respects user cap and context-window constraints - Store model_config on bot instance instead of copying fields into model_info - Add OUTPUT_RATIO and _estimate_output_tokens for output budget estimation - Add min_tokens chain (caller estimate -> _compute_max_tokens -> API) - Handle LengthExceedException in LeanTranslator retry paths - Update ContextReviewerAgent to read context_window from model_config - Fix LiteLLM base_url passthrough in create_chatbot - Update tests accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #143