Skip to content

fix: dbpool#118

Open
zextrasGiovanniDefacci wants to merge 1 commit into
develfrom
fix-dbpool
Open

fix: dbpool#118
zextrasGiovanniDefacci wants to merge 1 commit into
develfrom
fix-dbpool

Conversation

@zextrasGiovanniDefacci
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the test DB pool initialization to align with the newer Carbonio/Zimbra DB pool API and bumps the Carbonio dependency version used by the build.

Changes:

  • Replace DbPool.startup() with DbPool.global() in the Zimbra test simulator DB initialization.
  • Rework the test org.openzal.zal.db.DbPool helper from inheritance to a small delegating wrapper around com.zimbra.cs.db.DbPool.
  • Bump carbonio.version from 4.27.12 to 4.27.14 in pom.xml.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/test/java/org/openzal/zal/mailbox/ZalZimbraSimulator.java Updates HSQL test DB init to use the newer DbPool.global() initialization entrypoint.
src/test/java/org/openzal/zal/db/DbPool.java Adjusts the test helper to delegate to the new DB pool API rather than extending the upstream class.
pom.xml Updates the Carbonio dependency version property.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +5 to +7
public class DbPool {

public static void startup() {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants