fix: dbpool#118
Open
zextrasGiovanniDefacci wants to merge 1 commit into
Open
Conversation
keshavbhatt
approved these changes
May 29, 2026
frisonisland
approved these changes
May 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the test DB pool initialization to align with the newer Carbonio/Zimbra DB pool API and bumps the Carbonio dependency version used by the build.
Changes:
- Replace
DbPool.startup()withDbPool.global()in the Zimbra test simulator DB initialization. - Rework the test
org.openzal.zal.db.DbPoolhelper from inheritance to a small delegating wrapper aroundcom.zimbra.cs.db.DbPool. - Bump
carbonio.versionfrom4.27.12to4.27.14inpom.xml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/test/java/org/openzal/zal/mailbox/ZalZimbraSimulator.java |
Updates HSQL test DB init to use the newer DbPool.global() initialization entrypoint. |
src/test/java/org/openzal/zal/db/DbPool.java |
Adjusts the test helper to delegate to the new DB pool API rather than extending the upstream class. |
pom.xml |
Updates the Carbonio dependency version property. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5
to
+7
| public class DbPool { | ||
|
|
||
| public static void startup() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.